From: Pedro Alves <palves@redhat.com>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Cc: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v8 4/6] gdb: introduce 'all_non_exited_process_targets' and 'switch_to_target_no_thread'
Date: Thu, 14 May 2020 12:12:51 +0100 [thread overview]
Message-ID: <ae9e62a1-9502-e037-81cb-5c83cded6d73@redhat.com> (raw)
In-Reply-To: <SN6PR11MB28934AF2ED222B0623F33AB0C4BC0@SN6PR11MB2893.namprd11.prod.outlook.com>
On 5/14/20 9:44 AM, Aktemur, Tankut Baris wrote:
> Christian suggested adding a comment here to state why a set was needed.
> I thought about this:
>
> /* Inferiors may share targets. To eliminate duplicates, use a set. */
Sure, sounds good.
(Note I had done one change compared to your previous version I forgot
to mention -- the "#include <set>" should be in the .h file, rather
than in the .c file, because std::set is used in the .h file already.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-05-14 11:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 20:53 [PATCH v8 0/6] Handle already-exited threads in 'stop_all_threads' Pedro Alves
2020-05-13 20:53 ` [PATCH v8 1/6] gdb: protect some 'regcache_read_pc' calls Pedro Alves
2020-05-13 20:53 ` [PATCH v8 2/6] gdb/infrun: move a 'regcache_read_pc' call down to first use Pedro Alves
2020-05-13 20:53 ` [PATCH v8 3/6] gdb/infrun: extract out a code piece into 'mark_non_executing_threads' function Pedro Alves
2020-05-13 20:53 ` [PATCH v8 4/6] gdb: introduce 'all_non_exited_process_targets' and 'switch_to_target_no_thread' Pedro Alves
2020-05-14 8:44 ` Aktemur, Tankut Baris
2020-05-14 11:12 ` Pedro Alves [this message]
2020-05-14 11:23 ` Aktemur, Tankut Baris
2020-05-13 20:53 ` [PATCH v8 5/6] gdb/infrun: enable/disable thread events of all targets in stop_all_threads Pedro Alves
2020-05-14 8:44 ` Aktemur, Tankut Baris
2020-05-14 11:16 ` Pedro Alves
2020-05-14 11:30 ` Aktemur, Tankut Baris
2020-05-13 20:53 ` [PATCH v8 6/6] gdb/infrun: handle already-exited threads when attempting to stop Pedro Alves
2020-05-14 8:47 ` Aktemur, Tankut Baris
2020-05-14 11:16 ` Pedro Alves
2020-05-14 11:40 ` Aktemur, Tankut Baris
2020-05-14 18:00 ` Tom de Vries
2020-05-14 18:54 ` Aktemur, Tankut Baris
2020-05-14 18:58 ` Pedro Alves
2020-05-15 7:53 ` Aktemur, Tankut Baris
2020-05-15 10:14 ` Pedro Alves
2020-05-15 10:17 ` Tom de Vries
2020-05-15 10:35 ` Pedro Alves
2020-05-15 11:53 ` Tom de Vries
2020-05-15 12:02 ` Pedro Alves
2020-05-15 14:16 ` Tom de Vries
2020-05-15 15:46 ` Pedro Alves
2020-05-15 17:17 ` Tom de Vries
2020-05-18 6:18 ` [PATCH][gdb/testsuite] Warn about leaked global array Tom de Vries
2020-05-18 10:41 ` Pedro Alves
2020-05-19 16:34 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9e62a1-9502-e037-81cb-5c83cded6d73@redhat.com \
--to=palves@redhat.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox