From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v1.2 1/3] Introduce gdb::function_view
Date: Thu, 23 Feb 2017 14:59:00 -0000 [thread overview]
Message-ID: <adc29164-3b0f-f8c4-450e-43ecdfe128e1@redhat.com> (raw)
In-Reply-To: <86ino1ar9e.fsf@gmail.com>
On 02/23/2017 02:58 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> gdb/ChangeLog:
>> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>>
>> * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New.
>> (SFILES): Add $(SUBDIR_UNITTEST_SRCS).
>> (COMMON_OBS): Add $(SUBDIR_UNITTEST_OBS).
>> (%.o) <unittests/%.c>: New pattern.
>> (INIT_FILES): Add $(SUBDIR_UNITTESTS_SRCS).
>> * common/function-view.h: New file.
>> * unittests/function-view-selftests.c: New file.
>
> Patch is good to me. Nit, CL entry on configure.ac is missing.
Oh, I completely forgot to update the CL. Thanks for noticing.
I'll fix before pushing.
Anyone plans to review patch #3?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-23 14:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 14:50 [PATCH 0/3] Introduce gdb::function_view & fix completion bug Pedro Alves
2017-02-22 14:50 ` [PATCH 2/3] Use gdb::function_view in iterate_over_symtabs & co Pedro Alves
2017-02-22 22:40 ` Yao Qi
2017-02-22 14:50 ` [PATCH 3/3] Fix gdb.base/completion.exp with --target_board=dwarf4-gdb-index Pedro Alves
2017-02-23 16:02 ` Yao Qi
2017-02-23 17:12 ` Pedro Alves
2017-02-23 17:24 ` [PATCH v2 0/2] " Pedro Alves
2017-02-23 17:24 ` [PATCH v2 2/2] " Pedro Alves
2017-02-24 15:34 ` Yao Qi
2017-02-24 17:15 ` Pedro Alves
2017-02-23 17:24 ` [PATCH v2 1/2] symtab.c: Small refactor Pedro Alves
2017-02-23 21:45 ` Yao Qi
2017-02-24 17:45 ` Pedro Alves
2017-02-22 14:50 ` [PATCH 1/3] Introduce gdb::function_view Pedro Alves
2017-02-22 15:15 ` Simon Marchi
2017-02-22 17:40 ` Pedro Alves
2017-02-22 17:49 ` [PATCH v1.1 " Pedro Alves
2017-02-22 22:12 ` Yao Qi
2017-02-23 14:49 ` Pedro Alves
2017-02-23 15:11 ` Yao Qi
2017-02-23 15:20 ` Pedro Alves
2017-02-23 15:34 ` Yao Qi
2017-02-22 22:23 ` Yao Qi
2017-02-23 14:50 ` [PATCH v1.2 " Pedro Alves
2017-02-23 14:58 ` Yao Qi
2017-02-23 14:59 ` Pedro Alves [this message]
2017-02-22 18:02 ` [PATCH " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc29164-3b0f-f8c4-450e-43ecdfe128e1@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox