From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78700 invoked by alias); 23 Feb 2017 14:59:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78690 invoked by uid 89); 23 Feb 2017 14:59:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:bbc637e, H*f:sk:86ino1a, H*i:sk:86ino1a, H*MI:sk:86ino1a X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Feb 2017 14:59:40 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1959D804F6; Thu, 23 Feb 2017 14:59:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8E18B1215; Thu, 23 Feb 2017 14:59:39 +0000 (UTC) Subject: Re: [PATCH v1.2 1/3] Introduce gdb::function_view To: Yao Qi References: <1487775033-32699-1-git-send-email-palves@redhat.com> <1487775033-32699-2-git-send-email-palves@redhat.com> <8636f39b5e1e2cbdeabbf8dfd999e709@polymtl.ca> <4c8528d8-0115-3bf3-0a16-42f44be580a9@redhat.com> <20baebcd-0f6a-89ca-ef34-503795171d43@redhat.com> <20170222222316.xaeqa67lmil52c7j@localhost> <86ino1ar9e.fsf@gmail.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 23 Feb 2017 14:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86ino1ar9e.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00626.txt.bz2 On 02/23/2017 02:58 PM, Yao Qi wrote: > Pedro Alves writes: > >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * Makefile.in (SUBDIR_UNITTESTS_SRCS, SUBDIR_UNITTESTS_OBS): New. >> (SFILES): Add $(SUBDIR_UNITTEST_SRCS). >> (COMMON_OBS): Add $(SUBDIR_UNITTEST_OBS). >> (%.o) : New pattern. >> (INIT_FILES): Add $(SUBDIR_UNITTESTS_SRCS). >> * common/function-view.h: New file. >> * unittests/function-view-selftests.c: New file. > > Patch is good to me. Nit, CL entry on configure.ac is missing. Oh, I completely forgot to update the CL. Thanks for noticing. I'll fix before pushing. Anyone plans to review patch #3? Thanks, Pedro Alves