From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Change inferior_to_inferior_object to return a gdbpy_ref
Date: Wed, 02 Jan 2019 20:18:00 -0000 [thread overview]
Message-ID: <adb0daeee7b774a811e5de5609b83b14@polymtl.ca> (raw)
In-Reply-To: <20190102170136.437-1-tom@tromey.com>
On 2019-01-02 12:01, Tom Tromey wrote:
> Most callers of inferior_to_inferior_object already use a gdbpy_ref,
> so this changes inferior_to_inferior_object to return one. Doing this
> revealed that create_thread_object was not correctly handling the case
> where inferior_to_inferior_object failed, so this patch fixes this as
> well.
This LGTM, thanks!
Simon
prev parent reply other threads:[~2019-01-02 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 17:01 Tom Tromey
2019-01-02 20:18 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adb0daeee7b774a811e5de5609b83b14@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox