From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10919 invoked by alias); 2 Jan 2019 20:18:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10897 invoked by uid 89); 2 Jan 2019 20:18:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Jan 2019 20:18:08 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x02KI2IC000317 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 2 Jan 2019 15:18:06 -0500 Received: by simark.ca (Postfix, from userid 112) id 305D41E7AF; Wed, 2 Jan 2019 15:18:02 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 965DF1E05F; Wed, 2 Jan 2019 15:18:01 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 02 Jan 2019 20:18:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Change inferior_to_inferior_object to return a gdbpy_ref In-Reply-To: <20190102170136.437-1-tom@tromey.com> References: <20190102170136.437-1-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00043.txt.bz2 On 2019-01-02 12:01, Tom Tromey wrote: > Most callers of inferior_to_inferior_object already use a gdbpy_ref, > so this changes inferior_to_inferior_object to return one. Doing this > revealed that create_thread_object was not correctly handling the case > where inferior_to_inferior_object failed, so this patch fixes this as > well. This LGTM, thanks! Simon