From: WANG Xuerui <i.swmail@xen0n.name>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Xi Ruoyao <xry111@xry111.site>,
gdb-patches@sourceware.org
Cc: Hui Li <lihui@loongson.cn>, Lulu Cheng <chenglulu@loongson.cn>,
Mingcong Bai <jeffbai@aosc.io>
Subject: Re: [PATCH] gdb: LoongArch: Recognize LoongArch v1.10 store conditional instructions
Date: Wed, 20 Aug 2025 18:57:35 +0800 [thread overview]
Message-ID: <ad553d0b-4ccd-4f72-9fd3-87fcafaa901d@xen0n.name> (raw)
In-Reply-To: <9d8a7bab-e3fe-3083-e6ce-12b9ce48192b@loongson.cn>
On 8/19/25 16:45, Tiezhu Yang wrote:
> On 2025/8/19 下午3:33, Xi Ruoyao wrote:
>> We can't put a breakpoint in the middle of a ll/sc atomic sequence,
>> recognize the sc.q, screl.w, and screl.d instructions added in LoongArch
>
> sc.q, ll.acq.{w/d}, sc.rel.{w/d}
Lulu Cai said the manual was incorrect (actually the encoding table was
correct):
https://inbox.sourceware.org/binutils/f751042e-842d-5c60-6cb5-f3b6eb09aae2@loongson.cn/
"The instructions are llacq.[wd] and screl.[wd] instead of
ll.acq.[wd] and sc.rel.[wd]. This is a mistake in the main text of the
LoongArch ISA manual V1.10; the correct names can be found in Appendix B."
> [snip]
>
> The encodings for the instructions that you're handling look correct
> to me. I prefer using ll.acq.w, ll.acq.d, sc.rel.w, sc.rel.d in the
> code comments to make consistent with the manual.
So this is not necessary.
>
> If no more comments, I will amend these when applying in the next week,
> no need to send v2.
>
> Thanks,
> Tiezhu
>
next prev parent reply other threads:[~2025-08-20 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 7:33 Xi Ruoyao
2025-08-19 8:45 ` Tiezhu Yang
2025-08-20 10:57 ` WANG Xuerui [this message]
2025-08-21 1:18 ` Tiezhu Yang
2025-08-25 12:12 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad553d0b-4ccd-4f72-9fd3-87fcafaa901d@xen0n.name \
--to=i.swmail@xen0n.name \
--cc=chenglulu@loongson.cn \
--cc=gdb-patches@sourceware.org \
--cc=jeffbai@aosc.io \
--cc=lihui@loongson.cn \
--cc=xry111@xry111.site \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox