From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8SxRBVWqpWhjzgcAWB0awg (envelope-from ) for ; Wed, 20 Aug 2025 06:58:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=xen0n.name header.i=@xen0n.name header.a=rsa-sha256 header.s=mail header.b=Wq1v2SSs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 10AED1E0B3; Wed, 20 Aug 2025 06:58:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C98FA1E048 for ; Wed, 20 Aug 2025 06:58:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 01488385DDC2 for ; Wed, 20 Aug 2025 10:58:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01488385DDC2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=xen0n.name header.i=@xen0n.name header.a=rsa-sha256 header.s=mail header.b=Wq1v2SSs Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) by sourceware.org (Postfix) with ESMTPS id AF843385DC37 for ; Wed, 20 Aug 2025 10:57:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF843385DC37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xen0n.name ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF843385DC37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=115.28.160.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755687460; cv=none; b=VKUZjs8FjtmlL23xCg9JY3VBVE+tn/H/TXd64Gbn5WSJq4SG5gkJa+kSBjlcYwPNfLQ0elKn7jVuMe3Z7iLRBTa8A32jaMxHmlznjl6MSydUg1+utF0ORw8FSG6HY9bvTcmY8M0yyb/x4OZ8FVHPjVvHpU/LTF4ar1BsmnqQXEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755687460; c=relaxed/simple; bh=RwOi5tYEH8IssWcwPNqU1GdE2libF7KRyLpIb/8NHJU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SeCgQhIShOLzq4I4fQerYaF4j9ojNnjw5a/dGWe735lSPsShmQ8QitLlTZC4ReO2Mr20RbsSls7enyMTDEl5lTXjVg8VSCKCRFIihKjLB49WHcVZfN3sepEPtki869R1rgtTPd3+VqtJdh2auiZEevshus5ZkgWy/U12+/yjrnk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF843385DC37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1755687456; bh=RwOi5tYEH8IssWcwPNqU1GdE2libF7KRyLpIb/8NHJU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Wq1v2SSsPTcsPaejg89HzW7jFn5iCAect+4SYQxC5NzCdylR9YHACAgO/hNg8IsXz LzohgWsVqgYucNT3QyNmV2lhu1f7g6X5yBTmfyM69LrrWDGgwWZJ2pXqkeVvA1xaj5 RtROLMf0XFDFlXgx2PEptrzfb4ITHBRRI0V3CbHE= Received: from [28.0.0.1] (unknown [101.230.109.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 6D0F4600FE; Wed, 20 Aug 2025 18:57:36 +0800 (CST) Message-ID: Date: Wed, 20 Aug 2025 18:57:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: LoongArch: Recognize LoongArch v1.10 store conditional instructions To: Tiezhu Yang , Xi Ruoyao , gdb-patches@sourceware.org Cc: Hui Li , Lulu Cheng , Mingcong Bai References: <20250819073626.46815-1-xry111@xry111.site> <9d8a7bab-e3fe-3083-e6ce-12b9ce48192b@loongson.cn> Content-Language: en-US From: WANG Xuerui In-Reply-To: <9d8a7bab-e3fe-3083-e6ce-12b9ce48192b@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/19/25 16:45, Tiezhu Yang wrote: > On 2025/8/19 下午3:33, Xi Ruoyao wrote: >> We can't put a breakpoint in the middle of a ll/sc atomic sequence, >> recognize the sc.q, screl.w, and screl.d instructions added in LoongArch > > sc.q, ll.acq.{w/d}, sc.rel.{w/d} Lulu Cai said the manual was incorrect (actually the encoding table was correct): https://inbox.sourceware.org/binutils/f751042e-842d-5c60-6cb5-f3b6eb09aae2@loongson.cn/ "The instructions are llacq.[wd] and screl.[wd] instead of ll.acq.[wd] and sc.rel.[wd]. This is a mistake in the main text of the LoongArch ISA manual V1.10; the correct names can be found in Appendix B." > [snip] > > The encodings for the instructions that you're handling look correct > to me. I prefer using ll.acq.w, ll.acq.d, sc.rel.w, sc.rel.d in the > code comments to make consistent with the manual. So this is not necessary. > > If no more comments, I will amend these when applying in the next week, > no need to send v2. > > Thanks, > Tiezhu >