From: Luis Machado <luis.machado@linaro.org>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: [PATCH] [AArch64] Fix incorrectly-defined SVE macro
Date: Mon, 10 Aug 2020 11:57:44 -0300 [thread overview]
Message-ID: <ab7194fc-ded5-34f2-5da9-f8378218703c@linaro.org> (raw)
In-Reply-To: <0C61C5A0-A1DD-48B8-874A-96ED095F14F7@arm.com>
On 8/10/20 5:52 AM, Alan Hayward wrote:
>
>
>> On 7 Aug 2020, at 18:00, Luis Machado <luis.machado@linaro.org> wrote:
>>
>> The kernel has fixed this here:
>>
>> https://lore.kernel.org/patchwork/patch/1029011/
>>
>> We should do the same for GDB, which is still carrying an incorrect
>> definition of the macro. As stated in the kernel patch thread, this doesn't
>> actually change things because, luckily, the structs are of the same size.
>>
>
> Ouch. Good find.
>
>> YYYY-MM-DD Luis Machado <luis.machado@linaro.org>
>>
>> * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use
>> struct user_sve_header instead of struct sve_context.
>> ---
>> gdb/nat/aarch64-sve-linux-sigcontext.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gdb/nat/aarch64-sve-linux-sigcontext.h b/gdb/nat/aarch64-sve-linux-sigcontext.h
>> index 94fb1eca9c..52c5982608 100644
>> --- a/gdb/nat/aarch64-sve-linux-sigcontext.h
>> +++ b/gdb/nat/aarch64-sve-linux-sigcontext.h
>> @@ -166,7 +166,7 @@ struct user_sve_header {
>>
>> /* Offset from the start of struct user_sve_header to the register data */
>> #define SVE_PT_REGS_OFFSET \
>> - ((sizeof(struct sve_context) + (SVE_VQ_BYTES - 1)) \
>> + ((sizeof(struct user_sve_header) + (SVE_VQ_BYTES - 1)) \
>
> Matches the Kernel change exactly. So, approved!
Thanks. Pushed now.
prev parent reply other threads:[~2020-08-10 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 17:00 Luis Machado
2020-08-10 8:52 ` Alan Hayward
2020-08-10 14:57 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab7194fc-ded5-34f2-5da9-f8378218703c@linaro.org \
--to=luis.machado@linaro.org \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox