From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by sourceware.org (Postfix) with ESMTPS id 5E497386F018 for ; Mon, 10 Aug 2020 14:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E497386F018 Received: by mail-qt1-x843.google.com with SMTP id 6so6955146qtt.0 for ; Mon, 10 Aug 2020 07:57:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=INre9bVXEiHSUNQcU0hjDhG6a57xhtiPlZKRbt1+e+o=; b=dIaAOn1VlJevvjO+edP1ILMbOmR4G8xPl5jtTb5WgjFJ025FtrJEBoYSrKpN6zGD0I 03QzRSC5MPBl1XsxpR3lGmjJTy9iO2ipxNEKLhLW/6T58Mc8tLM9CJu3xxFBRtsd/El0 u32gU8s6eId3laYX+cE2QuZlt6J+Mt++r7NQTGXA9e6f6UrRJG5anqKquHfyNBbbGuno 6hk9hDJfOfl6SntuXGxW64A6VWXh/j59O+RIZJMmiw90qHxVvFUHTOj80BUGsH3a/xD1 dIlEBtUEQqIsp6e2tTt1NN4gEwM3o+33okc8cI+8UzoaUwB3qfWl/yKy7gjs2JdO88hW ka8Q== X-Gm-Message-State: AOAM531iyrkrD6ShvlaAjB1SZ9w5qcyDMeH6mbvVlCujsa68lcboCgQn puAk9VJsDRIc+c+65QBYJHapv16ErqWsgw== X-Google-Smtp-Source: ABdhPJwZNlcX728XQGBVOEJQ799YxECyDTXTREk46l3Bhnrk7AHu94hz9j55L1OnfJh868V2vE6viQ== X-Received: by 2002:ac8:7341:: with SMTP id q1mr27168358qtp.8.1597071466902; Mon, 10 Aug 2020 07:57:46 -0700 (PDT) Received: from ?IPv6:2804:7f0:8283:6f2c:b77d:47b2:730b:373? ([2804:7f0:8283:6f2c:b77d:47b2:730b:373]) by smtp.gmail.com with ESMTPSA id m66sm14385828qkf.86.2020.08.10.07.57.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2020 07:57:46 -0700 (PDT) Subject: Re: [PATCH] [AArch64] Fix incorrectly-defined SVE macro To: Alan Hayward Cc: gdb-patches , nd References: <20200807170003.1761-1-luis.machado@linaro.org> <0C61C5A0-A1DD-48B8-874A-96ED095F14F7@arm.com> From: Luis Machado Message-ID: Date: Mon, 10 Aug 2020 11:57:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <0C61C5A0-A1DD-48B8-874A-96ED095F14F7@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 14:57:48 -0000 On 8/10/20 5:52 AM, Alan Hayward wrote: > > >> On 7 Aug 2020, at 18:00, Luis Machado wrote: >> >> The kernel has fixed this here: >> >> https://lore.kernel.org/patchwork/patch/1029011/ >> >> We should do the same for GDB, which is still carrying an incorrect >> definition of the macro. As stated in the kernel patch thread, this doesn't >> actually change things because, luckily, the structs are of the same size. >> > > Ouch. Good find. > >> YYYY-MM-DD Luis Machado >> >> * nat/aarch64-sve-linux-sigcontext.h (SVE_PT_REGS_OFFSET): Use >> struct user_sve_header instead of struct sve_context. >> --- >> gdb/nat/aarch64-sve-linux-sigcontext.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gdb/nat/aarch64-sve-linux-sigcontext.h b/gdb/nat/aarch64-sve-linux-sigcontext.h >> index 94fb1eca9c..52c5982608 100644 >> --- a/gdb/nat/aarch64-sve-linux-sigcontext.h >> +++ b/gdb/nat/aarch64-sve-linux-sigcontext.h >> @@ -166,7 +166,7 @@ struct user_sve_header { >> >> /* Offset from the start of struct user_sve_header to the register data */ >> #define SVE_PT_REGS_OFFSET \ >> - ((sizeof(struct sve_context) + (SVE_VQ_BYTES - 1)) \ >> + ((sizeof(struct user_sve_header) + (SVE_VQ_BYTES - 1)) \ > > Matches the Kernel change exactly. So, approved! Thanks. Pushed now.