Re: [PATCH 2/2] [gdb] Exclude unavailable hardware threads in default worker-threads

[Tom de Vries <tdevries@suse.de>]

On 9/17/26 2:22 AM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Sorry I didn't reply to this earlier.  I saw it went in.
> 
> Tom> +#ifdef __linux__
> Tom> +#include <sched.h>
> Tom> +#endif
>   
> The autoconf wisdom is to do feature checks, not platform checks, a
> style that's generally used in gdb.  And you can see the result here,
> where the above turned into
> 
> +#if defined (__linux__) || defined (__CYGWIN__)
> 
> Tom> +	  /* Exclude unavailable hardware threads (for instance made
> Tom> +	     unavailable using taskset).  */
> Tom> +#ifdef __linux__
> Tom> +	  cpu_set_t cpus;
> Tom> +	  int res = sched_getaffinity (getpid (), sizeof (cpu_set_t), &cpus);
> 
> Likewise for functions.
> 
> Tom> +#else
> Tom> +	  /* Todo: handle other platforms.  */
> Tom> +#endif
> 
> gdb generally has stopped adding todo/FIXME/etc comments, mainly because
> nobody ever actually does them.  Sometimes there are exceptions for
> specific plans, I'm guilty of this myself with the Python safety code.
> But here I think leaving this out would be completely fine, it's
> implicit that ports to new hosts may be desirable.
> 

Hi Tom,

thanks for the review.

I've submitted a fix ( 
https://sourceware.org/pipermail/gdb-patches/2026-September/230427.html ).

Thanks,
- Tom

> thanks,
> Tom