From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WHhoFYDgq2oCsRYAWB0awg (envelope-from ) for ; Thu, 17 Sep 2026 08:43:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wV/M5ILG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=N0RfUNbe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n82YZAeY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8xPaMRv3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 49C0D1E06B; Thu, 17 Sep 2026 08:43:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 464F11E01F for ; Thu, 17 Sep 2026 08:43:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78C474BA79BA for ; Thu, 17 Sep 2026 12:43:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78C474BA79BA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wV/M5ILG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=N0RfUNbe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n82YZAeY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8xPaMRv3 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 37FF54BA2E0A for ; Thu, 17 Sep 2026 12:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37FF54BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 37FF54BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789648997; cv=none; b=CuI6of9aTl45OEHMWy8U8+BF2Iu6UwsU/3w9XBhZ1n4d61Jdjiv9UG9ubpQrxaODsFpdnhbQjVk7CCM79waqzRb1239V22GBkPp2I97LX1GXkPQwv5Roh4LcTM7PT4UBdyERh+XHDhxIBNqwvdUxFkA7VOpjS1ds2G1GnvkunjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789648997; c=relaxed/simple; bh=ZPHnED3pIphlSF+5OvFTgwBohm1PnQ9X0NJcJkivJcQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Hq+z3MRHVjzQ36JyqLWkYkB9tM/nrGXKTSXS7iC+blzHihVvmUo4juCjXyIX4MgjZCOgvVwbQYr15hmnxn+oa1wUDEnafY2nDNiMWntd9cq6wVuzMGGSKG1S6Ygs0nRj2EBz0vexqTCBFqauc7P5RJ/k2oQkGA2i1hi3LBEpcW8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wV/M5ILG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=N0RfUNbe; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=n82YZAeY; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8xPaMRv3 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37FF54BA2E0A Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CBCBF2002F; Thu, 17 Sep 2026 12:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789648991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbdOn506GOhLumaglFfNucsULCNZ/jVb0NxqESLDCgQ=; b=wV/M5ILGfTrAYuotStr2nuUb9hAHhqBix63ae6LmtGAmHVTuK4KggXDvXPGnwWrEX9yEd6 BapysDa3/SKUfJxkY/BDktQrma7iQW38B9R9LDmrt19IaydBGGn752qDOgaf9lVuzTh0mo J5cZeWsJrjTQEguir3tfnQeKlsKL7Ms= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789648991; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbdOn506GOhLumaglFfNucsULCNZ/jVb0NxqESLDCgQ=; b=N0RfUNbeesoNgs3R1wSH2udT2U7OvE0GnSJZmyYh6kTiBN2Ct+dtud3zTNjtRcaD1XUPP7 LP+EWi4itQIYx1CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=n82YZAeY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8xPaMRv3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1789648987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbdOn506GOhLumaglFfNucsULCNZ/jVb0NxqESLDCgQ=; b=n82YZAeYIXbEH9dgzbx7rB6H6qy6W0Dz/K6hpAIjQ9/RlYE+j7P8Si6mjKJmu9jJ1WmssV XnrelESZHSxj0CN02B/TeiCb7vlpbs5s/D+ieDJLZVvNekcy6UeaEFjZZ4CIdb08bWIx6v jE7ThMkbnh7PPWxlAPA2ka1Iu7U3UM4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1789648987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbdOn506GOhLumaglFfNucsULCNZ/jVb0NxqESLDCgQ=; b=8xPaMRv3UO8/KZJ/nYntA9yDSCFihi/CG9Wo251ChBey0wsIQ4U+3vRTxFl1+owJdqUWtu Ky5/AK4c5hz68QCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 93C2413786; Thu, 17 Sep 2026 12:43:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hfetGFvgq2piDwAAD6G6ig (envelope-from ); Thu, 17 Sep 2026 12:43:07 +0000 Message-ID: Date: Thu, 17 Sep 2026 14:43:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb] Exclude unavailable hardware threads in default worker-threads To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260906154838.139837-1-tdevries@suse.de> <20260906154838.139837-2-tdevries@suse.de> <87h5jo680u.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87h5jo680u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: CBCBF2002F X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/17/26 2:22 AM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Sorry I didn't reply to this earlier. I saw it went in. > > Tom> +#ifdef __linux__ > Tom> +#include > Tom> +#endif > > The autoconf wisdom is to do feature checks, not platform checks, a > style that's generally used in gdb. And you can see the result here, > where the above turned into > > +#if defined (__linux__) || defined (__CYGWIN__) > > Tom> + /* Exclude unavailable hardware threads (for instance made > Tom> + unavailable using taskset). */ > Tom> +#ifdef __linux__ > Tom> + cpu_set_t cpus; > Tom> + int res = sched_getaffinity (getpid (), sizeof (cpu_set_t), &cpus); > > Likewise for functions. > > Tom> +#else > Tom> + /* Todo: handle other platforms. */ > Tom> +#endif > > gdb generally has stopped adding todo/FIXME/etc comments, mainly because > nobody ever actually does them. Sometimes there are exceptions for > specific plans, I'm guilty of this myself with the Python safety code. > But here I think leaving this out would be completely fine, it's > implicit that ports to new hosts may be desirable. > Hi Tom, thanks for the review. I've submitted a fix ( https://sourceware.org/pipermail/gdb-patches/2026-September/230427.html ). Thanks, - Tom > thanks, > Tom