Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Breakage on builder Solaris11-sparcv9-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2
  2019-09-13  1:04 Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate gdb-buildbot
@ 2019-09-13  1:04 ` gdb-buildbot
  2019-09-13  1:11 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
  2019-09-13  1:32 ` Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate Andrew Burgess
  2 siblings, 0 replies; 4+ messages in thread
From: gdb-buildbot @ 2019-09-13  1:04 UTC (permalink / raw)
  To: gdb-patches, gdb-patches, Andrew Burgess

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'gdb: Have 'maint info sections' print all sections again'
Revision: aa17805fb9a3a1983a510ba425b682fba03410c2

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    gdbsupport/gdb_tilde_expand.o
  CXX    gdbsupport/gdb_vecs.o
  CXX    gdbsupport/job-control.o
  CXX    gdbsupport/netstuff.o
  CXX    gdbsupport/new-op.o
  CXX    gdbsupport/pathstuff.o
  CXX    gdbsupport/posix-strerror.o
  CXX    gdbsupport/print-utils.o
  CXX    gdbsupport/ptid.o
  CXX    gdbsupport/rsp-low.o
  CXX    gdbsupport/run-time-clock.o
  CXX    gdbsupport/scoped_mmap.o
  CXX    gdbsupport/selftest.o
  CXX    gdbsupport/signals-state-save-restore.o
  CXX    gdbsupport/signals.o
  CXX    gdbsupport/tdesc.o
  CXX    gdbsupport/vec.o
  CXX    gdbsupport/xml-utils.o
  CXX    gdbtypes.o
  CXX    gnu-v2-abi.o
  CXX    gnu-v3-abi.o
  CXX    go-exp.o
  CXX    go-lang.o
  CXX    go-typeprint.o
  CXX    go-valprint.o
  CXX    guile/guile.o
  CXX    inf-child.o
  CXX    inf-loop.o
  CXX    infcall.o
  CXX    infcmd.o
  CXX    inferior.o
  CXX    inflow.o
  CXX    infrun.o
  CXX    inline-frame.o
  CXX    interps.o
  CXX    jit.o
  CXX    language.o
  CXX    linespec.o
In file included from ../../binutils-gdb/gdb/infrun.c:26:0:
../../binutils-gdb/gdb/inferior.h: In function void handle_vfork_child_exec_or_exit(int):
../../binutils-gdb/gdb/inferior.h:605:26: warning: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf may be used uninitialized in this function [-Wmaybe-uninitialized]
   { set_current_inferior (m_saved_inf); }
     ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
../../binutils-gdb/gdb/infrun.c:936:6: note: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf was declared here
      maybe_restore_inferior;
      ^~~~~~~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/inferior.h:49:0,
                 from ../../binutils-gdb/gdb/infrun.c:26:
../../binutils-gdb/gdb/progspace.h:314:31: warning: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace may be used uninitialized in this function [-Wmaybe-uninitialized]
   { set_current_program_space (m_saved_pspace); }
     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/infrun.c:936:6: note: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace was declared here
      maybe_restore_inferior;
      ^~~~~~~~~~~~~~~~~~~~~~
  CXX    location.o
  CXX    m2-exp.o
  CXX    m2-lang.o
  CXX    m2-typeprint.o
  CXX    m2-valprint.o
  CXX    macrocmd.o
  CXX    macroexp.o
  CXX    macroscope.o
  CXX    macrotab.o
  CXX    main.o
  CXX    maint-test-options.o
  CXX    maint-test-settings.o
  CXX    maint.o
  CXX    mdebugread.o
  CXX    mem-break.o
../../binutils-gdb/gdb/maint.c: In constructor maint_print_section_data::maint_print_section_data(objfile*, const char*, bfd*):
../../binutils-gdb/gdb/maint.c:304:47: error: call of overloaded log10(int&) is ambiguous
     index_digits = ((int) log10 (section_count)) + 1;
                                               ^
In file included from /usr/gcc/7/lib/gcc/sparcv9-sun-solaris2.11/7.3.0/include-fixed/math.h:24:0,
                 from /usr/gcc/7/include/c++/7.3.0/bits/std_abs.h:40,
                 from /usr/gcc/7/include/c++/7.3.0/cstdlib:77,
                 from /usr/gcc/7/include/c++/7.3.0/stdlib.h:36,
                 from ../gnulib/import/stdlib.h:36,
                 from ../../binutils-gdb/gdb/gdbsupport/common-defs.h:91,
                 from ../../binutils-gdb/gdb/defs.h:28,
                 from ../../binutils-gdb/gdb/maint.c:23:
/usr/gcc/7/lib/gcc/sparcv9-sun-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:70:15: note: candidate: double std::log10(double)
 extern double log10 __P((double));
               ^~~~~
/usr/gcc/7/lib/gcc/sparcv9-sun-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:170:15: note: candidate: float std::log10(float)
  inline float log10(float __X) { return __log10f(__X); }
               ^~~~~
/usr/gcc/7/lib/gcc/sparcv9-sun-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:209:21: note: candidate: long double std::log10(long double)
  inline long double log10(long double __X) { return __log10l(__X); }
                     ^~~~~
  CXX    memattr.o
gmake[2]: *** [Makefile:1636: maint.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build/gdb'
gmake[1]: *** [Makefile:9229: all-gdb] Error 2
gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-sparcv9/solaris11-sparcv9-m64/build'
gmake: *** [Makefile:851: all] Error 2
program finished with exit code 2
elapsedTime=290.041162


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Oh dear.  I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate
@ 2019-09-13  1:04 gdb-buildbot
  2019-09-13  1:04 ` Breakage on builder Solaris11-sparcv9-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2 gdb-buildbot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: gdb-buildbot @ 2019-09-13  1:04 UTC (permalink / raw)
  To: gdb-patches, gdb-patches, Andrew Burgess

My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	gdb: Have 'maint info sections' print all sections again
	aa17805fb9a3a1983a510ba425b682fba03410c2

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Breakage on builder Solaris11-amd64-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2
  2019-09-13  1:04 Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate gdb-buildbot
  2019-09-13  1:04 ` Breakage on builder Solaris11-sparcv9-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2 gdb-buildbot
@ 2019-09-13  1:11 ` gdb-buildbot
  2019-09-13  1:32 ` Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate Andrew Burgess
  2 siblings, 0 replies; 4+ messages in thread
From: gdb-buildbot @ 2019-09-13  1:11 UTC (permalink / raw)
  To: gdb-patches, gdb-patches, Andrew Burgess

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'gdb: Have 'maint info sections' print all sections again'
Revision: aa17805fb9a3a1983a510ba425b682fba03410c2

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+


+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    gdbsupport/new-op.o
  CXX    gdbsupport/pathstuff.o
  CXX    gdbsupport/posix-strerror.o
  CXX    gdbsupport/print-utils.o
  CXX    gdbsupport/ptid.o
  CXX    gdbsupport/rsp-low.o
  CXX    gdbsupport/run-time-clock.o
  CXX    gdbsupport/scoped_mmap.o
  CXX    gdbsupport/selftest.o
  CXX    gdbsupport/signals-state-save-restore.o
  CXX    gdbsupport/signals.o
  CXX    gdbsupport/tdesc.o
  CXX    gdbsupport/vec.o
  CXX    gdbsupport/xml-utils.o
  CXX    gdbtypes.o
  CXX    gnu-v2-abi.o
  CXX    gnu-v3-abi.o
  CXX    go-exp.o
  CXX    go-lang.o
  CXX    go-typeprint.o
  CXX    go-valprint.o
  CXX    i386-sol2-nat.o
  CXX    guile/guile.o
  CXX    i386-sol2-tdep.o
  CXX    i386-tdep.o
  CXX    i387-tdep.o
  CXX    inf-child.o
  CXX    inf-loop.o
  CXX    infcall.o
  CXX    infcmd.o
  CXX    inferior.o
  CXX    inflow.o
  CXX    infrun.o
  CXX    inline-frame.o
  CXX    interps.o
  CXX    jit.o
In file included from ../../binutils-gdb/gdb/infrun.c:26:0:
../../binutils-gdb/gdb/inferior.h: In function void handle_vfork_child_exec_or_exit(int):
../../binutils-gdb/gdb/inferior.h:605:26: warning: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf may be used uninitialized in this function [-Wmaybe-uninitialized]
   { set_current_inferior (m_saved_inf); }
     ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
../../binutils-gdb/gdb/infrun.c:936:6: note: *((void*)(& maybe_restore_inferior)+40).scoped_restore_current_inferior::m_saved_inf was declared here
      maybe_restore_inferior;
      ^~~~~~~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/inferior.h:49:0,
                 from ../../binutils-gdb/gdb/infrun.c:26:
../../binutils-gdb/gdb/progspace.h:314:31: warning: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace may be used uninitialized in this function [-Wmaybe-uninitialized]
   { set_current_program_space (m_saved_pspace); }
     ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/infrun.c:936:6: note: *((void*)(& maybe_restore_inferior)+32).scoped_restore_current_program_space::m_saved_pspace was declared here
      maybe_restore_inferior;
      ^~~~~~~~~~~~~~~~~~~~~~
  CXX    language.o
  CXX    linespec.o
  CXX    location.o
  CXX    m2-exp.o
  CXX    m2-lang.o
  CXX    m2-typeprint.o
  CXX    m2-valprint.o
  CXX    macrocmd.o
  CXX    macroexp.o
  CXX    macroscope.o
  CXX    macrotab.o
  CXX    main.o
  CXX    maint-test-options.o
  CXX    maint-test-settings.o
  CXX    maint.o
  CXX    mdebugread.o
  CXX    mem-break.o
  CXX    memattr.o
../../binutils-gdb/gdb/maint.c: In constructor maint_print_section_data::maint_print_section_data(objfile*, const char*, bfd*):
../../binutils-gdb/gdb/maint.c:304:47: error: call of overloaded log10(int&) is ambiguous
     index_digits = ((int) log10 (section_count)) + 1;
                                               ^
In file included from /usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/include-fixed/math.h:24:0,
                 from /usr/gcc/7/include/c++/7.3.0/bits/std_abs.h:40,
                 from /usr/gcc/7/include/c++/7.3.0/cstdlib:77,
                 from /usr/gcc/7/include/c++/7.3.0/stdlib.h:36,
                 from ../gnulib/import/stdlib.h:36,
                 from ../../binutils-gdb/gdb/gdbsupport/common-defs.h:91,
                 from ../../binutils-gdb/gdb/defs.h:28,
                 from ../../binutils-gdb/gdb/maint.c:23:
/usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:70:15: note: candidate: double std::log10(double)
 extern double log10 __P((double));
               ^~~~~
/usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:170:15: note: candidate: float std::log10(float)
  inline float log10(float __X) { return __log10f(__X); }
               ^~~~~
/usr/gcc/7/lib/gcc/x86_64-pc-solaris2.11/7.3.0/include-fixed/iso/math_iso.h:209:21: note: candidate: long double std::log10(long double)
  inline long double log10(long double __X) { return __log10l(__X); }
                     ^~~~~
gmake[2]: *** [Makefile:1636: maint.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build/gdb'
gmake[1]: *** [Makefile:9229: all-gdb] Error 2
gmake[1]: Leaving directory '/opt/gdb-buildbot/home/solaris11-amd64/solaris11-amd64-m64/build'
gmake: *** [Makefile:851: all] Error 2
program finished with exit code 2
elapsedTime=476.565072


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Oh dear.  I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate
  2019-09-13  1:04 Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate gdb-buildbot
  2019-09-13  1:04 ` Breakage on builder Solaris11-sparcv9-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2 gdb-buildbot
  2019-09-13  1:11 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
@ 2019-09-13  1:32 ` Andrew Burgess
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Burgess @ 2019-09-13  1:32 UTC (permalink / raw)
  To: gdb-patches

* gdb-buildbot@sergiodj.net <gdb-buildbot@sergiodj.net> [2019-09-12 21:04:31 -0400]:

> My lords, ladies, gentlemen, members of the public.
> 
> It is a matter of great regret and sadness to inform you that commit:
> 
> 	gdb: Have 'maint info sections' print all sections again
> 	aa17805fb9a3a1983a510ba425b682fba03410c2
> 
> might have made GDB unwell.  Since I am just your Butler BuildBot,
> I kindly ask that a human superior officer double-check this.
> 
> Please note that if you are reading this message on gdb-patches, there might
> be other builders broken.

Apologies for causing this breakage.

I have pushed the patch below which should resolve this issue.

Thanks,
Andrew

--

commit ec6c8338a89b0ec022b66ed3efdd1577e6449d6d
Author: Andrew Burgess <andrew.burgess@embecosm.com>
Date:   Thu Sep 12 21:23:37 2019 -0400

    gdb: Force use of float version of log10
    
    This commit:
    
      commit aa17805fb9a3a1983a510ba425b682fba03410c2
      Date:   Sat Aug 31 23:44:40 2019 +0100
    
          gdb: Have 'maint info sections' print all sections again
    
    introduced a use of log10 that took an int as a parameter.
    Unfortunately this was causing a compilation error on Solaris, see:
    
      https://sourceware.org/ml/gdb-patches/2019-09/msg00230.html
      https://sourceware.org/ml/gdb-patches/2019-09/msg00231.html
    
    because there was only a float, double, or long double version of
    log10, and the compiler doesn't know which to choose.
    
    This commit should resolve this issue by casting the argument to
    float.
    
    gdb/ChangeLog:
    
            * maint.c (maint_print_section_data::maint_print_section_data):
            Force use of 'float log10 (float)' by casting the argument to
            float.

diff --git a/gdb/maint.c b/gdb/maint.c
index 286ec310135..1a621a17191 100644
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -301,7 +301,7 @@ struct maint_print_section_data
       arg(arg)
   {
     int section_count = gdb_bfd_count_sections (abfd);
-    index_digits = ((int) log10 (section_count)) + 1;
+    index_digits = ((int) log10 ((float) section_count)) + 1;
   }
 
 private:


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-09-13  1:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-13  1:04 Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate gdb-buildbot
2019-09-13  1:04 ` Breakage on builder Solaris11-sparcv9-m64, revision aa17805fb9a3a1983a510ba425b682fba03410c2 gdb-buildbot
2019-09-13  1:11 ` Breakage on builder Solaris11-amd64-m64, " gdb-buildbot
2019-09-13  1:32 ` Oh dear. I regret to inform you that commit aa17805fb9a3a1983a510ba425b682fba03410c2 might be unfortunate Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox