Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Charlie Jenkins <charlie@rivosinc.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: snatu@whileone.in, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PATCH v3] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native
Date: Mon, 28 Apr 2025 12:35:27 -0700	[thread overview]
Message-ID: <aA_Yf3gfiZ7oAIe9@ghost> (raw)
In-Reply-To: <87msc06wi7.fsf@redhat.com>

On Mon, Apr 28, 2025 at 06:12:16PM +0100, Andrew Burgess wrote:
> Charlie Jenkins <charlie@rivosinc.com> writes:
> 
> > On Thu, Apr 24, 2025 at 12:19:14PM +0000, snatu@whileone.in wrote:
> >> From: Sameer Natu <snatu@whileone.in>
> >> 
> >> A v3 re-spin of the original patch.
> >> Tested with latest kernel 6.14.2 on RISCV QEMU.
> >> Removed Magic Numbers from v2 patch and worked on review comments of v2 patch.
> >
> > Thanks for working on this!
> >
> > Can you add a co-developed-by tag for the original author?
> >
> > You also don't need to have [PATCH] twice in the header!
> >
> > There are a handful of erroneous spaces at the end of lines.
> >
> > I tested this patch and I noticed that the vector instructions are not
> > being decoded.
> >
> > Breakpoint 1, vector () at main.S:4
> > 4               vsetvli t0, a0, e32, m4, ta, ma
> > 1: x/i $pc
> > => 0x55555555566c <vector>:     .insn   4, 0x0d2572d
> 
> Does an `objdump` built from the same tree decode these instructions?
> Wondering if this is a problem with the objdump disassembler library, or
> a problem with the way GDB uses that library.

Yes, `objdump -d` from the same tree dumps the instruction. Perhaps some
entry needs to be added to `riscv_gdbarch_init()` in gdb/riscv-tdep.c?

- Charlie

> 
> Thanks,
> Andrew
> 

  reply	other threads:[~2025-04-28 19:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 12:19 snatu
2025-04-24 16:51 ` Andrew Burgess
2025-04-26  6:06 ` Charlie Jenkins
2025-04-28 17:12   ` Andrew Burgess
2025-04-28 19:35     ` Charlie Jenkins [this message]
2025-04-29  6:54       ` Charlie Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aA_Yf3gfiZ7oAIe9@ghost \
    --to=charlie@rivosinc.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=snatu@whileone.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox