From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4XdgG6/YD2g8xwoAWB0awg (envelope-from ) for ; Mon, 28 Apr 2025 15:36:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=CzoauMoN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5E0D31E10E; Mon, 28 Apr 2025 15:36:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6F8B71E0C0 for ; Mon, 28 Apr 2025 15:36:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 88F6B3858401 for ; Mon, 28 Apr 2025 19:36:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 88F6B3858401 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=CzoauMoN Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id A14953858031 for ; Mon, 28 Apr 2025 19:35:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A14953858031 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A14953858031 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745868932; cv=none; b=s2tRu5aW/WNOsGMPYplYbwOAaGs7gatexUYP+CLOjI4ZP64pcWSxmLW6qy7ZJhclmbP3EMuBm5MgGN6+p7owwXCPfbeBlM/Y04cwE5n3XyFd5dG8tIBnn9ia41aWgJ/hkSXDit9bEHLKSorDXB3Sp3G2XzLrlLGV44lZG5PDABU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745868932; c=relaxed/simple; bh=uhLQ8QyhpKVSqjM6OaCfJyVHCkjW7AkE5mjsXc7g9JQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=uHpw3JY2JgOUE2e40/TUxNGm2mXf5PobavSxPu3bMqtkbKVvXyVtUoqfGqKwMe+jWNvPb3avAKQgRu/dSbjipNFKn3Jb2/Ma3y5EZWvRtkH2yq3ebrKvMeP7ArS92NJGNDVHkufpK2jmHeB6rNh1Uqcv/xDZFrBJZ3l06ZIm8oM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A14953858031 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-b0b2d1f2845so3675240a12.3 for ; Mon, 28 Apr 2025 12:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1745868930; x=1746473730; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1pCuAgbIGgy9WM9XU5IJZn3+8pYAGw3SUZafFW79ji4=; b=CzoauMoNtSy10RI4FVrGQyhLaYqf7zu53EaMrEcz4D99AB6YAaw7gqlzVcPjczCZhO yHBxmS0fvIH6espWLOLnRpkxfUw0Dgy6vE2Peg/juUzMB2PCI54A8IZdrVEO5/Zqn9T+ K+m632RdBZXzollpsBz2Wl3ATNpyfttqJUKGZgM5zoZwp9czTNAMxPBwS0DJFhO8vI/u mGPAPMvD/uYyZlsGs7zAhxlTYOjOoUG5RptFIojiz7C5J/jUxim3e425g+4C5q+2MrQq vMZhDD5GCaLNeXzFSiGPQlAU7cUl8rQDTs9ewFI6nA3iHtEweUJi/Llv1gj/9EssElNO 0/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745868930; x=1746473730; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1pCuAgbIGgy9WM9XU5IJZn3+8pYAGw3SUZafFW79ji4=; b=w1Lm5E/SXvJnxJ75mWaGrlw2NLviU80awza08hIablXB5GQyj1JDXxmHfscntsA2wC tFiG7CeXOrSoDd7Ol+uSb7R7sl7Iq+uNkpdlarjqb0v4+1rACkm17EGTauITMO0fNvJV kbX9pKSbHiCCf3rORypvcl4OOdGkp1Tdu325yGvq3DA7WY/IbKa7Lqkk87YCT1I6fEyu W3m3bAGJn9+yO7fx5s7a7QTf9p+xWwfEjIJ5oXqIZUv6Ur7OyMO6nfrLBZaeBTnmurSo jTB3+WWpWBVQ6gq9sZftDwAZSGg9j8VeJObV0I7OnoHH5NwCt/8vswppZEZjaEfgz88Z b/Xg== X-Forwarded-Encrypted: i=1; AJvYcCXeobMmrgsRi7f+nKkAdmqbojUc+ihkJEgyUppcxqupJMjCEctW/jmNd82XLyX5wFgvgFFzgeqhLgTz0w==@sourceware.org X-Gm-Message-State: AOJu0YwcY1QnRUOHfDqqT9Mt/lUcTnC5jAqaMJhP9UITgfsWQn4CpDr2 /Jn+yZ0x4CcmzzEKwVru4WmOKL5ywN3R8vMvDU5Oaq8P6IKYmhw5BCv1TC6ENnOQtjw6oCSLMsf eueo= X-Gm-Gg: ASbGnctD4IKvRdkgsKEgcNdLbWDyVLrl4BuEKgVFp9oVlzno3QnksdFdzqKgLk4HtpP KbQbh2DdjxD9oM0vnvXsuq/6B3iKyUpr8PlyouR95xABhVQbeZRaBveQPorJ7/oLCpk9zTTlyXG 2HGqTQ1kvmiLCSCsD8O1WA2ZaowwHD0DB+A3xOIBBgxpvpDCLsoMVmoM8vZrb35O6RMUJTJ+oPt eJmoalyPNHQOsBAkmKsEr2+ZovI9DSh7w6rBETOjXOVFyvFt9Fn+IVbMJAFOen4AkQPQtobAPFn U3tD0p8Ya8od4zG/u7ISSy/OKAMpMPcyQrbx X-Google-Smtp-Source: AGHT+IGrp88v0fCDZcS6GyzOMRy8Ab6LSMPuH35UMi+LCQ9nOis0BWXbk1j7YM0jfNMk4wO5a3Pi2Q== X-Received: by 2002:a05:6a21:7802:b0:1ee:e2ac:5159 with SMTP id adf61e73a8af0-209568273f1mr420809637.19.1745868930710; Mon, 28 Apr 2025 12:35:30 -0700 (PDT) Received: from ghost ([2601:647:6700:64d0:5842:f05a:498b:82d0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25967766sm8418552b3a.82.2025.04.28.12.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 12:35:29 -0700 (PDT) Date: Mon, 28 Apr 2025 12:35:27 -0700 From: Charlie Jenkins To: Andrew Burgess Cc: snatu@whileone.in, gdb-patches@sourceware.org Subject: Re: [PATCH] [PATCH v3] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native Message-ID: References: <20250424121915.1203050-2-snatu@whileone.in> <87msc06wi7.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87msc06wi7.fsf@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Apr 28, 2025 at 06:12:16PM +0100, Andrew Burgess wrote: > Charlie Jenkins writes: > > > On Thu, Apr 24, 2025 at 12:19:14PM +0000, snatu@whileone.in wrote: > >> From: Sameer Natu > >> > >> A v3 re-spin of the original patch. > >> Tested with latest kernel 6.14.2 on RISCV QEMU. > >> Removed Magic Numbers from v2 patch and worked on review comments of v2 patch. > > > > Thanks for working on this! > > > > Can you add a co-developed-by tag for the original author? > > > > You also don't need to have [PATCH] twice in the header! > > > > There are a handful of erroneous spaces at the end of lines. > > > > I tested this patch and I noticed that the vector instructions are not > > being decoded. > > > > Breakpoint 1, vector () at main.S:4 > > 4 vsetvli t0, a0, e32, m4, ta, ma > > 1: x/i $pc > > => 0x55555555566c : .insn 4, 0x0d2572d > > Does an `objdump` built from the same tree decode these instructions? > Wondering if this is a problem with the objdump disassembler library, or > a problem with the way GDB uses that library. Yes, `objdump -d` from the same tree dumps the instruction. Perhaps some entry needs to be added to `riscv_gdbarch_init()` in gdb/riscv-tdep.c? - Charlie > > Thanks, > Andrew >