From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Replicate src dir in build dir
Date: Wed, 20 Sep 2017 08:17:00 -0000 [thread overview]
Message-ID: <a9f35736ce6a71d217b18f55c3e8f3e8@polymtl.ca> (raw)
In-Reply-To: <867ewtbxwb.fsf@gmail.com>
On 2017-09-20 10:02, Yao Qi wrote:
>>> @@ -2941,9 +2949,9 @@ ifeq ($(DEPMODE),depmode=gcc3)
>>> # into place if the compile succeeds. We need this because gcc does
>>> # not atomically write the dependency output file.
>>> override COMPILE.post = -c -o $@ -MT $@ -MMD -MP \
>>> - -MF $(DEPDIR)/$(basename $(@F)).Tpo
>>> -override POSTCOMPILE = @mv $(DEPDIR)/$(basename $(@F)).Tpo \
>>> - $(DEPDIR)/$(basename $(@F)).Po
>>> + -MF $(@D)/$(DEPDIR)/$(@F).Tpo
>>> +override POSTCOMPILE = @mv $(@D)/$(DEPDIR)/$(@F).Tpo \
>>> + $(@D)/$(DEPDIR)/$(@F).Po
>>> else
>>> override COMPILE.pre = source='$<' object='$@' libtool=no \
>>> DEPDIR=$(DEPDIR) $(DEPMODE) $(depcomp) $(CC)
>>
>> I have never tested it, but I assume the "depcomp" mode of dependency
>> management will have to be updated too.
>
> I don't understand this comment. The only change in on dependency
> tracking is that .Po file is moved to a new place (.deps/amd64.Po ->
> ./arch/.deps/amd64.o.Po). The file contents don't change.
>
> $ diff -u .deps/amd64.Po ./arch/.deps/amd64.o.Po
> --- .deps/amd64.Po 2017-09-20 07:57:04.903381133 +0000
> +++ ./arch/.deps/amd64.o.Po 2017-09-20 07:40:35.995718460 +0000
> @@ -1,4 +1,4 @@
> -amd64.o: ../../binutils-gdb/gdb/arch/amd64.c \
> +arch/amd64.o: ../../binutils-gdb/gdb/arch/amd64.c \
> ../../binutils-gdb/gdb/arch/amd64.h
> ../../binutils-gdb/gdb/arch/tdesc.h \
> build-gnulib/import/stdint.h
> ../../binutils-gdb/gdb/common/x86-xstate.h \
> build-gnulib/import/stdlib.h \
I was wondering if this line needed changing
override COMPILE.pre = source='$<' object='$@' libtool=no \
DEPDIR=$(DEPDIR) $(DEPMODE) $(depcomp) $(CC)
In particular, is DEPDIR treated as relative to the created object file
or relative to the current working directory by depcomp. I honestly
don't even know when this actually used.
Simon
next prev parent reply other threads:[~2017-09-20 8:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 14:42 Yao Qi
2017-09-19 20:44 ` Simon Marchi
2017-09-20 8:04 ` Yao Qi
2017-09-20 8:17 ` Simon Marchi [this message]
2017-09-20 14:26 ` Yao Qi
2017-09-20 11:26 ` Pedro Alves
2017-09-20 16:49 ` Yao Qi
2017-09-20 17:45 ` Pedro Alves
2017-09-29 19:23 ` Yao Qi
2017-10-03 20:02 ` Pedro Alves
2017-10-03 20:14 ` Kamil Rytarowski
2017-10-03 22:04 ` Pedro Alves
2017-10-04 9:46 ` Kamil Rytarowski
2017-10-06 9:29 ` Yao Qi
2017-10-04 11:41 ` Pedro Alves
2017-10-06 10:21 ` Yao Qi
2017-10-08 3:24 ` Tom Tromey
2017-10-08 21:04 ` Yao Qi
2017-10-11 1:25 ` Yao Qi
2017-10-11 3:26 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9f35736ce6a71d217b18f55c3e8f3e8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox