Re: [RFC] Replicate src dir in build dir

[Pedro Alves <palves@redhat.com>]

On 09/29/2017 08:23 PM, Yao Qi wrote:

> 
> I tested this patch by build gdb for each different target triplets
> respectively,
> 
> aarch64-elf aarch64-rtems aarch64-freebsd aarch64-linux alpha-elf
> alpha-linux alpha-netbsd alpha-openbsd arm-elf arm-wince-pe arm-linux
> arm-netbsd arm-symbianelf avr cris-elf frv-elf h8300-elf i386-elf
> i386-darwin i386-dicos i386-freebsd i386-netbsdelf i386-openbsd
> i386-nto i386-solaris i386-linux i386-gnu i386-cygwin i386-mingw32
> i386-go32 ia64-linux-gnu ia64-vms lm32-elf m32c-elf m32r-elf m32r-linux
> m68hc11-elf m68k-elf m68k-linux m68k-netbsd m68k-openbsd m88k-openbsd
> mep-elf microblaze-xilinx-elf microblaze-linux-gnu mips-elf moxie-elf
> ms1-elf nios2-elf nios2-linux-gnu hppa-elf hppa-linux hppa-netbsd
> hppa-openbsd powerpc-eabi powerpc-freebsd powerpc-netbsd powerpc-openbsd
> powerpc-linux powerpc-lynx178 rl78-elf rx-elf s390-linux-gnu score-elf
> sh-elf sh-linux sh-openbsd sh64-elf sh64-linux sh64-openbsd sparc64-linux
> sparc-linux sparc-freebsd sparc64-freebsd sparc-netbsd sparc64-netbsd
> sparc-openbsd sparc64-openbsd spu-elf tic6x-elf tic6x-uclinux v850-elf
> vax-netbsd vax-openbsd x86_64-linux-gnu x86_64-darwin x86_64-dicos
> x86_64-elf x86_64-freebsd x86_64-mingw32 x86_64-netbsd x86_64-openbsd
> x86_64-rtems xstormy16-elf xtensa-elf xtensa-linux

OOC, this wasn't with gdb/gdb_buildall.sh, was it?

> +
> +case "${targ}" in
> +*-*-freebsd* | *-*-kfreebsd*-gnu)
> +	os_obs="fbsd-tdep.o solib-svr4.o";;
> +*-*-netbsd* | *-*-knetbsd*-gnu)
> +	os_obs="nbsd-tdep.o solib-svr4.o";;
> +*-*-openbsd*)
> +	os_obs="obsd-tdep.o solib-svr4.o";;

I'm surprised that there's no case for GNU/Linux
here, with at least linux-tdep.c and solib-svr4.o,
off hand.  Maybe glibc-tdep.o too.

There could be a case here for mingw/cygwin ports,
containing windows-tdep.o.

And case for darwin ports with solib-darwin.o.

But none of that are blockers.  I'm totally fine with
incremental progress.  We can always improve on top.

> +esac
> +
>  # map target info into gdb names.

I think IBWN to add a comment before each of the
arch / os sections, so that it's really obvious
what the different sections are about to new readers.
This "map target info ..." preexisting comment just above
might use an update too.

But generally, I'm happy with this.  Thanks much for doing it.

Thanks,
Pedro Alves