Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdbsupport: rename source files to .cc
Date: Thu, 13 Feb 2020 18:34:00 -0000	[thread overview]
Message-ID: <a9a2ffee-1399-9603-065a-ca1caa75da3d@redhat.com> (raw)
In-Reply-To: <874kvur3aw.fsf@tromey.com>

On 2/13/20 2:04 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> This patch renames the .c source files in gdbsupport to .cc.
> 
> I support this change.
> 
> Note that this would let us remove these hacks from gdbsupport/Makefile.am:
> 
> override CXX += $(CXX_DIALECT)
> 
> override CC := $(CXX)
> override CFLAGS := $(CXXFLAGS)
> 
> AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
> 
> 
> The CC and CFLAGS settings can be removed entirely.  AM_CFLAGS can be
> renamed to AM_CXXFLAGS, and the CXX_DIALECT can be put there.

I had preferred overriding CXX instead of CXXFLAGS for the reasons
explained at [1] [2].  Sounds like that defeats it.

[1] https://sourceware.org/ml/gdb-patches/2020-01/msg00453.html
[2] https://sourceware.org/ml/gdb-patches/2020-01/msg00460.html

Thanks,
Pedro Alves


  parent reply	other threads:[~2020-02-13 18:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 22:54 Simon Marchi
2020-02-12 22:54 ` [PATCH 2/2] gdbserver: " Simon Marchi
2020-02-13 14:05   ` Tom Tromey
2020-02-13 14:48     ` Simon Marchi
2020-02-13 15:08       ` Tom Tromey
2020-02-13 15:28       ` Aktemur, Tankut Baris
2020-02-13 14:05 ` [PATCH 1/2] gdbsupport: " Tom Tromey
2020-02-13 14:41   ` Simon Marchi
2020-02-13 18:34   ` Pedro Alves [this message]
2020-02-13 21:22     ` Simon Marchi
2020-02-13 21:26       ` Pedro Alves
2020-02-13 21:31         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9a2ffee-1399-9603-065a-ca1caa75da3d@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox