From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48692 invoked by alias); 13 Feb 2020 18:34:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48684 invoked by uid 89); 13 Feb 2020 18:34:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=explained X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 18:34:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581618846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dx61dWrdERBoXU0bC5xFerzJWBlsnI9otvm0Mkyiui4=; b=RNkQHq3Yp8Wzkt4G3fy3qBX3qJXHovbPiXbHTvT+xWvHWl8ZAlRVZST6p11uI+vyjbpGny z/waEjiETKEZbCUsJZmkbGgIBGiyY7tXuqOeKJzVt7dssMJHaApDWc19SyW0TBXPKxL2dJ aPb4JEnHwW6ydbM7XbuODCKR48d3+qo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-RfGA44hMOACeJd8MLd-31w-1; Thu, 13 Feb 2020 13:34:00 -0500 Received: by mail-wr1-f71.google.com with SMTP id m15so2683805wrs.22 for ; Thu, 13 Feb 2020 10:34:00 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id w19sm3914991wmc.22.2020.02.13.10.33.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Feb 2020 10:33:58 -0800 (PST) Subject: Re: [PATCH 1/2] gdbsupport: rename source files to .cc To: Tom Tromey , Simon Marchi References: <20200212225340.28865-1-simon.marchi@efficios.com> <874kvur3aw.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 13 Feb 2020 18:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <874kvur3aw.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00520.txt.bz2 On 2/13/20 2:04 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> This patch renames the .c source files in gdbsupport to .cc. > > I support this change. > > Note that this would let us remove these hacks from gdbsupport/Makefile.am: > > override CXX += $(CXX_DIALECT) > > override CC := $(CXX) > override CFLAGS := $(CXXFLAGS) > > AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS) > > > The CC and CFLAGS settings can be removed entirely. AM_CFLAGS can be > renamed to AM_CXXFLAGS, and the CXX_DIALECT can be put there. I had preferred overriding CXX instead of CXXFLAGS for the reasons explained at [1] [2]. Sounds like that defeats it. [1] https://sourceware.org/ml/gdb-patches/2020-01/msg00453.html [2] https://sourceware.org/ml/gdb-patches/2020-01/msg00460.html Thanks, Pedro Alves