From: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <Shahab.Vahedi@synopsys.com>
Subject: Re: [PATCH] gdb: Delay releasing target_desc_up in more cases
Date: Thu, 8 Oct 2020 16:54:31 +0000 [thread overview]
Message-ID: <a7adc445-4544-620f-c0e6-6246b206bacb@synopsys.com> (raw)
In-Reply-To: <20201008151758.2116169-1-andrew.burgess@embecosm.com>
Hi Andrew,
With a little bit of an extra change [1], everything works fine. Thank you for
fixing this in ARC port as well.
Cheers,
Shahab
[1] Changing the "arc_create_traget_description" proto type in the header file
diff --git a/gdb/arch/arc.h b/gdb/arch/arc.h
index 16257596748..1e0e8cd9635 100644
--- a/gdb/arch/arc.h
+++ b/gdb/arch/arc.h
@@ -70,7 +70,7 @@ struct arc_arch_features
The only external client of this must be the gdbserver which manipulates
the returned data. */
-target_desc *arc_create_target_description
+target_desc_up arc_create_target_description
(const struct arc_arch_features &features);
#else
next prev parent reply other threads:[~2020-10-08 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 19:47 [PATCH] gdb: Have allocate_target_description return a unique_ptr Andrew Burgess
2020-10-05 19:52 ` Simon Marchi
2020-10-07 11:41 ` Pedro Alves
2020-10-08 9:28 ` Andrew Burgess
2020-10-08 15:17 ` [PATCH] gdb: Delay releasing target_desc_up in more cases Andrew Burgess
2020-10-08 16:54 ` Shahab Vahedi via Gdb-patches [this message]
2020-10-09 10:47 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7adc445-4544-620f-c0e6-6246b206bacb@synopsys.com \
--to=gdb-patches@sourceware.org \
--cc=Shahab.Vahedi@synopsys.com \
--cc=andrew.burgess@embecosm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox