From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Have allocate_target_description return a unique_ptr
Date: Mon, 5 Oct 2020 15:52:21 -0400 [thread overview]
Message-ID: <52c060fa-4dff-7fc6-fd9b-3f8fe53b6ba9@simark.ca> (raw)
In-Reply-To: <20201005194728.699823-1-andrew.burgess@embecosm.com>
On 2020-10-05 3:47 p.m., Andrew Burgess wrote:
> Below is a rebased version of a patch I posted here:
>
> https://sourceware.org/pipermail/gdb-patches/2020-July/170639.html
>
> this recieved positive feedback at the time but was buried in some
> other thread so may not have been widely seen. I thought it was
> probably worth reposting this before merging just to see if anyone
> else had any thoughts.
>
> There's a lot of change here, but all of the *.c files that are marked
> 'Regenerate' in the ChangeLog follow much the same pattern, review one
> of them and you've reviewed them all.
>
> Thanks,
> Andrew
You already have a +1 from me on this (I was the one who pushed you to
do it :)).
Simon
next prev parent reply other threads:[~2020-10-05 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 19:47 Andrew Burgess
2020-10-05 19:52 ` Simon Marchi [this message]
2020-10-07 11:41 ` Pedro Alves
2020-10-08 9:28 ` Andrew Burgess
2020-10-08 15:17 ` [PATCH] gdb: Delay releasing target_desc_up in more cases Andrew Burgess
2020-10-08 16:54 ` Shahab Vahedi via Gdb-patches
2020-10-09 10:47 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c060fa-4dff-7fc6-fd9b-3f8fe53b6ba9@simark.ca \
--to=simark@simark.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox