Re: [PATCH v2] use DISABLE_COPY_AND_ASSIGN in switch_thru_all_uis

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-01-15 4:28 p.m., Lancelot SIX via Gdb-patches wrote:
> In switch_thru_all_uis,  a pre-c++11 way of removing copy constructor
> and assignment operator is used.
> 
> This patch uses the DISABLE_COPY_AND_ASSIGN macro which does the right
> thing for pre and post c++11.
> 
> gdb/Changelog:
> 
> 	* top.h (switch_thru_all_uis): Use DISABLE_COPY_AND_ASSIGN.
> ---
>  gdb/top.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/top.h b/gdb/top.h
> index a31b19ae954..f58bebbb385 100644
> --- a/gdb/top.h
> +++ b/gdb/top.h
> @@ -173,6 +173,8 @@ class switch_thru_all_uis
>      current_ui = ui_list;
>    }
>  
> +  DISABLE_COPY_AND_ASSIGN (switch_thru_all_uis);
> +
>    /* If done iterating, return true; otherwise return false.  */
>    bool done () const
>    {
> @@ -190,11 +192,6 @@ class switch_thru_all_uis
>  
>   private:
>  
> -  /* No need for these.  They are intentionally not defined
> -     anywhere.  */
> -  switch_thru_all_uis &operator= (const switch_thru_all_uis &);
> -  switch_thru_all_uis (const switch_thru_all_uis &);
> -
>    /* Used to iterate through the UIs.  */
>    struct ui *m_iter;
>  
> 

Thanks, this is ok.

Simon