Re: [PATCH] use DISABLE_COPY_AND_ASSIGN in switch_thru_all_uis

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-01-15 2:49 p.m., Lancelot SIX via Gdb-patches wrote:
> In switch_thru_all_uis,  a pre-c++11 way of removing copy constructor
> and assignment operator is used.
> 
> This patch uses the DISABLE_COPY_AND_ASSIGN macro which does the right
> thing for pre and post c++11.
> 
> gdb/Changelog:
> 
> 	* top.h (switch_thru_all_uis): Use DISABLE_COPY_AND_ASSIGN.
> ---
>  gdb/top.h | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/gdb/top.h b/gdb/top.h
> index a31b19ae954..d912ea97190 100644
> --- a/gdb/top.h
> +++ b/gdb/top.h
> @@ -190,10 +190,7 @@ class switch_thru_all_uis
>  
>   private:
>  
> -  /* No need for these.  They are intentionally not defined
> -     anywhere.  */
> -  switch_thru_all_uis &operator= (const switch_thru_all_uis &);
> -  switch_thru_all_uis (const switch_thru_all_uis &);
> +  DISABLE_COPY_AND_ASSIGN (switch_thru_all_uis);
>  
>    /* Used to iterate through the UIs.  */
>    struct ui *m_iter;
> 

Thanks, this LGTM.  Maybe just move the DISABLE_COPY_AND_ASSIGN so it's
right below the constructor (it no longer needs to be in the private
section, given we know we are using C++ >= 11).

Simon