From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [committed][gdb] Fix prop->const_val uses in gdbtypes.c
Date: Wed, 5 Aug 2020 08:46:10 -0400 [thread overview]
Message-ID: <a41c48cd-46c8-51e0-8c84-cfde92478a98@polymtl.ca> (raw)
In-Reply-To: <d17e07ac-a5e3-05bc-38d3-b441df1ddc46@suse.de>
On 2020-08-05 6:33 a.m., Tom de Vries wrote:
> [ was: Re: [PATCH 3/3] gdb: remove TYPE_DYN_PROP_ADDR ]
>
> On 8/5/20 11:20 AM, Tom de Vries wrote:
>> On 8/2/20 1:59 AM, Simon Marchi via Gdb-patches wrote:
>>> Remove TYPE_DYN_PROP_ADDR, replacing its uses with calling
>>> dynamic_prop::const_val directly.
>>>
>>> gdb/ChangeLog:
>>>
>>> * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with
>>> dynamic_prop::const_val.
>>>
>>
>>
>> This patch causes the following regression for me:
>> ...
>> FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b
>> ...
>> (and 185 more, all for fortran test-cases).
>>
>>> return (prop != nullptr && prop->kind () == PROP_CONST
>>> - && !TYPE_DYN_PROP_ADDR (prop));
>>> + && prop->const_val () != 0);
>>> }
>>>
>>
>> Hmm, isn't that supposed to be "== 0" ?
>
> Committed patch that fixes the regressions.
>
> Thanks,
> - Tom
>
Arggh, thanks for fixing this.
Simon
next prev parent reply other threads:[~2020-08-05 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 23:59 [PATCH 0/3] Remove last dynamic prop macros Simon Marchi
2020-08-01 23:59 ` [PATCH 1/3] gdb: remove TYPE_DYN_PROP_BATON Simon Marchi
2020-08-01 23:59 ` [PATCH 2/3] gdb: remove TYPE_DYN_PROP_KIND Simon Marchi
2020-08-01 23:59 ` [PATCH 3/3] gdb: remove TYPE_DYN_PROP_ADDR Simon Marchi
2020-08-05 9:20 ` Tom de Vries
2020-08-05 10:33 ` [committed][gdb] Fix prop->const_val uses in gdbtypes.c Tom de Vries
2020-08-05 12:46 ` Simon Marchi [this message]
2020-08-05 12:56 ` Tom de Vries
2020-08-04 18:06 ` [PATCH 0/3] Remove last dynamic prop macros Tom Tromey
2020-08-04 18:48 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a41c48cd-46c8-51e0-8c84-cfde92478a98@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox