From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 831903861028 for ; Wed, 5 Aug 2020 12:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 831903861028 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 075CkIDx023789 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 5 Aug 2020 08:46:23 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 075CkIDx023789 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9E2A71E554; Wed, 5 Aug 2020 08:46:18 -0400 (EDT) Subject: Re: [committed][gdb] Fix prop->const_val uses in gdbtypes.c To: Tom de Vries , gdb-patches@sourceware.org References: <20200801235935.1110640-1-simon.marchi@polymtl.ca> <20200801235935.1110640-4-simon.marchi@polymtl.ca> <57dcb18b-d120-845e-6b90-e4a8f853f2cb@suse.de> From: Simon Marchi Message-ID: Date: Wed, 5 Aug 2020 08:46:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 5 Aug 2020 12:46:18 +0000 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-DCC: : antispam2020.polymtl.ca 1102; Body=1 Fuz1=1 Fuz2=1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 12:46:27 -0000 On 2020-08-05 6:33 a.m., Tom de Vries wrote: > [ was: Re: [PATCH 3/3] gdb: remove TYPE_DYN_PROP_ADDR ] > > On 8/5/20 11:20 AM, Tom de Vries wrote: >> On 8/2/20 1:59 AM, Simon Marchi via Gdb-patches wrote: >>> Remove TYPE_DYN_PROP_ADDR, replacing its uses with calling >>> dynamic_prop::const_val directly. >>> >>> gdb/ChangeLog: >>> >>> * gdbtypes.h (TYPE_DYN_PROP_ADDR): Remove, replace uses with >>> dynamic_prop::const_val. >>> >> >> >> This patch causes the following regression for me: >> ... >> FAIL: gdb.fortran/class-allocatable-array.exp: print this%_data%b >> ... >> (and 185 more, all for fortran test-cases). >> >>> return (prop != nullptr && prop->kind () == PROP_CONST >>> - && !TYPE_DYN_PROP_ADDR (prop)); >>> + && prop->const_val () != 0); >>> } >>> >> >> Hmm, isn't that supposed to be "== 0" ? > > Committed patch that fixes the regressions. > > Thanks, > - Tom > Arggh, thanks for fixing this. Simon