From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH][gdb] Update syscalls/{amd64,i386}-linux.xml
Date: Thu, 12 May 2022 11:00:04 +0200 [thread overview]
Message-ID: <a37d6309-aede-3e26-7a7c-5df8de28d52e@suse.de> (raw)
In-Reply-To: <adc40e4d-bab5-e8dc-ffe0-a25fceffb228@suse.de>
On 5/10/22 13:39, Tom de Vries wrote:
> Subject:
> Re: [PATCH][gdb] Update syscalls/{amd64,i386}-linux.xml
> From:
> Tom de Vries <tdevries@suse.de>
> Date:
> 5/10/22, 13:39
>
> To:
> Tom Tromey <tom@tromey.com>, Tom de Vries via Gdb-patches
> <gdb-patches@sourceware.org>
> CC:
> Simon Marchi <simark@simark.ca>
>
>
> On 5/9/22 19:19, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries via Gdb-patches
>>>>>>> <gdb-patches@sourceware.org> writes:
>>
>> Tom> diff --git a/gdb/syscalls/gen-header.py b/gdb/syscalls/gen-header.py
>>
>> Tom> +<!-- Copyright (C) 2009-%s Free Software Foundation, Inc.
>>
>> Tom> +"""
>> Tom> + % (time.strftime("%Y"), infname)
>>
>> It seems like overkill to have a python script just for a "here
>> document" and "date +%Y".
>>
>
> Ack, fixed.
>
>> Tom> +(
>> Tom> + python gen-header.py "<sys/syscall.h>"
>> Tom> +
>> Tom> + tmp=$(mktemp)
>> Tom> +
>> Tom> + echo '#include <sys/syscall.h>' \
>> Tom> + | gcc -E - -dD "$@" \
>> Tom> + | egrep '#define __NR_' \
>> Tom> + > $tmp
>> Tom> +
>> Tom> + echo '<syscalls_info>'
>> Tom> +
>> Tom> + while read line; do
>> Tom> + name=$(echo $line | awk '{print $2}' | sed 's/^__NR_//')
>> Tom> + nr=$(echo $line | awk '{print $3}')
>> Tom> + echo " <syscall name=\"$name\" number=\"$nr\"/>"
>> Tom> + done < $tmp
>> Tom> +
>> Tom> + echo '</syscalls_info>'
>>
>> Alternatively doing the whole thing in Python would also be alright.
>
> I've done things in bash for now, that's easier for me.
>
> Any further comments?
>
I've committed this fixup patch.
Thanks,
- Tom
> Attachments:
>
> 0006-gdb-tdep-Improve-gdb-syscalls-update-linux.sh.patch 2.8 KB
>
next prev parent reply other threads:[~2022-05-12 9:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 14:57 [PATCH][gdb/testsuite] Handle pipe2 syscall in gdb.base/catch-syscall.exp Tom de Vries via Gdb-patches
2022-05-05 11:47 ` [PATCH, v2][gdb/testsuite] " Tom de Vries via Gdb-patches
2022-05-05 11:49 ` [PATCH][gdb/tdep] Support catch syscall pipe2 for i386 Tom de Vries via Gdb-patches
2022-05-05 13:20 ` Simon Marchi via Gdb-patches
2022-05-09 10:26 ` [PATCH][gdb] Add gdb/syscalls/Makefile Tom de Vries via Gdb-patches
2022-05-09 14:41 ` Simon Marchi via Gdb-patches
2022-05-09 14:46 ` Tom de Vries via Gdb-patches
2022-05-09 10:39 ` [PATCH][gdb] Update syscalls/{amd64,i386}-linux.xml Tom de Vries via Gdb-patches
2022-05-09 14:48 ` Simon Marchi via Gdb-patches
2022-05-09 15:29 ` Tom de Vries via Gdb-patches
2022-05-09 15:40 ` Andreas Schwab
2022-05-09 15:42 ` Tom de Vries via Gdb-patches
2022-05-09 15:45 ` Andreas Schwab
2022-05-09 16:04 ` Tom de Vries via Gdb-patches
2022-05-09 17:19 ` Tom Tromey
2022-05-10 11:39 ` Tom de Vries via Gdb-patches
2022-05-12 9:00 ` Tom de Vries via Gdb-patches [this message]
2022-05-10 11:53 ` Tom de Vries via Gdb-patches
2022-05-16 16:07 ` Tom Tromey
2022-05-18 9:58 ` [committed][gdb/tdep] Add gdb/syscalls/update-linux-from-src.sh Tom de Vries via Gdb-patches
2022-05-05 13:23 ` [PATCH, v2][gdb/testsuite] Handle pipe2 syscall in gdb.base/catch-syscall.exp Simon Marchi via Gdb-patches
2022-05-09 10:18 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a37d6309-aede-3e26-7a7c-5df8de28d52e@suse.de \
--to=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tdevries@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox