Re: [users/palves/catch_exceptions] [PATCH] zap catch_exceptions (Re: [RFA] Change exceptions.h functions to use gdb::function_view)

[Pedro Alves <palves@redhat.com>]

On 09/28/2017 03:04 AM, Tom Tromey wrote:
> Pedro> Alright, I've pushed this patch below on the branch as well.  It
> Pedro> gets rid of catch_exceptions / catch_exceptions_with_msg.  The
> Pedro> latter is done mostly by getting rid of the remaining vestigial libgdb
> Pedro> wrapper functions, which are really pointless nowadays.  This results in
> Pedro> a good number of simplifications.
> 
> Thanks for doing this.  I'd started earlier, and did the catch_errors
> part, but I saw your mail before I finished; and I think your patch is a
> bit cleaner anyway.

Sorry about that.  :-/  I only did it because I thought you wouldn't
be able to...  Here's what happened on IRC:

 <tromey> thanks for the review palves 
 <tromey> it may be a while before I get to that [snip]
 <-- tromey has left this server
 <palves> tromey: ack.  I'm tired so I'm using that as procrastination :-P  i'm eliminating catch_errors using TRY/CATCH.  will show what it looks like in a bit.
 <palves> this exposes lots of cleanup opportunity.
 <palves> err, ENOTROMEY...

:-P

> I think my MI cleanup branch (still pending review) also touched these
> vestigial libgdb functions, but I don't mind rebasing that when the time
> comes.

I'll take a look at that.

Thanks,
Pedro Alves