From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79005 invoked by alias); 28 Sep 2017 09:13:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77940 invoked by uid 89); 28 Sep 2017 09:13:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=opportunity X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 09:13:34 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FFF9AB921; Thu, 28 Sep 2017 09:13:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1FFF9AB921 Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6871E86E63; Thu, 28 Sep 2017 09:13:32 +0000 (UTC) Subject: Re: [users/palves/catch_exceptions] [PATCH] zap catch_exceptions (Re: [RFA] Change exceptions.h functions to use gdb::function_view) To: Tom Tromey References: <20170927165302.30177-1-tom@tromey.com> <4098e86f-d084-fb3b-ea9b-0d5565ddd930@redhat.com> <87o9pvyjlb.fsf@pokyo> <7262baed-d54f-4c7c-abe3-b2bd90ff9562@redhat.com> <1f40ef50-9f1f-32f0-a71a-c97c404fd66f@redhat.com> <87zi9finni.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 28 Sep 2017 09:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87zi9finni.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00850.txt.bz2 On 09/28/2017 03:04 AM, Tom Tromey wrote: > Pedro> Alright, I've pushed this patch below on the branch as well. It > Pedro> gets rid of catch_exceptions / catch_exceptions_with_msg. The > Pedro> latter is done mostly by getting rid of the remaining vestigial libgdb > Pedro> wrapper functions, which are really pointless nowadays. This results in > Pedro> a good number of simplifications. > > Thanks for doing this. I'd started earlier, and did the catch_errors > part, but I saw your mail before I finished; and I think your patch is a > bit cleaner anyway. Sorry about that. :-/ I only did it because I thought you wouldn't be able to... Here's what happened on IRC: thanks for the review palves it may be a while before I get to that [snip] <-- tromey has left this server tromey: ack. I'm tired so I'm using that as procrastination :-P i'm eliminating catch_errors using TRY/CATCH. will show what it looks like in a bit. this exposes lots of cleanup opportunity. err, ENOTROMEY... :-P > I think my MI cleanup branch (still pending review) also touched these > vestigial libgdb functions, but I don't mind rebasing that when the time > comes. I'll take a look at that. Thanks, Pedro Alves