From: Pedro Alves <pedro@palves.net>
To: Sarang Patrange <spatrang@amd.com>, gdb-patches@sourceware.org
Cc: Lancelot Six <lancelot.six@amd.com>
Subject: Re: [PATCH] gdb/testsuite: replace hipcc with amdclang++ as the HIP compiler
Date: Fri, 31 Jul 2026 11:28:15 +0100 [thread overview]
Message-ID: <a2664698-fd68-4fdf-b958-4621571653a2@palves.net> (raw)
In-Reply-To: <20260715094533.3093704-1-spatrang@amd.com>
Hi!
On 2026-07-15 10:45, Sarang Patrange wrote:
> + # amdclang++ requires explicit --offload-arch. Explicitly
> + # pass one --offload-arch for each available device. But
> + # don't do it if the testcase explicitly used --offload-arch.
> + if {[lsearch -exact $options hip_no_offload_arch] == -1
This hip_no_offload_arch check shouldn't be in this patch. That option won't exist until some later
yet-sent-to-gdb-patches patch adds it. Noticed because I'm working on preparing said patch. :-)
> + && [lsearch -regexp $options "--offload-arch="] == -1} {
> + foreach gpu_target [hcc_amdgpu_targets] {
> + lappend new_options "early_flags=--offload-arch=$gpu_target"
next prev parent reply other threads:[~2026-07-31 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:45 Sarang Patrange
2026-07-17 10:28 ` Lancelot SIX
2026-07-31 10:28 ` Pedro Alves [this message]
2026-08-06 11:29 ` [PATCH v2] " Sarang Patrange
2026-08-17 20:41 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2664698-fd68-4fdf-b958-4621571653a2@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=spatrang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox