From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id adBHDD95bGpdGjcAWB0awg (envelope-from ) for ; Fri, 31 Jul 2026 06:30:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=s/i8KnEE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2E3FB1E099; Fri, 31 Jul 2026 06:30:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C1551E099 for ; Fri, 31 Jul 2026 06:30:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CBBE84BB5922 for ; Fri, 31 Jul 2026 10:30:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CBBE84BB5922 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=s/i8KnEE Received: from crocodile.ash.relay.mailchannels.net (crocodile.ash.relay.mailchannels.net [23.83.222.45]) by sourceware.org (Postfix) with ESMTPS id 9D9A54B19706 for ; Fri, 31 Jul 2026 10:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D9A54B19706 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D9A54B19706 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.222.45 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785493724; cv=none; b=pF7ZGScB3bcVay4TnoknewWfRn8z5irW/8kYHlKn/jMeDCJPym2QiZlnfZ4DB04CQiLhtGeuwrp5mz65XT60bYux4sYQFcWbQC2FESvR5g4gRVFKpa57bpj8j4CoSeXuV77l4GFsHym0Ur7qTbmnZQgKxB1g5nnMqzmgYVVxYSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785493724; c=relaxed/simple; bh=t81UuSJwZQ4IKgoyNfAzgaOq5g8TmeHZAN3pju/OkPo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=q96UuJ40SIhQjTl3PYvwlVm6Hgg2CybzsBLYT75KITRboLRE5PmQUjetZKvYQvuMD2etu3QTkpKmX4qEphvBfs5TxW77ZOrP1AFX3DHpRAVGscNnHTTDZmjm6SGLK3yxovz2FrvwIkjrxHeTv8fw5mZCMtqEi1T61PYHYVg5ccs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=s/i8KnEE DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D9A54B19706 X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 57EFF38216A; Fri, 31 Jul 2026 10:28:35 +0000 (UTC) Received: from pdx1-sub0-mail-a203.dreamhost.com (100-109-137-223.trex-nlb.outbound.svc.cluster.local [100.109.137.223]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1C2913827E8; Fri, 31 Jul 2026 10:28:35 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Little-Celery: 1d37234258850e43_1785493715175_1928770038 X-MC-Loop-Signature: 1785493715174:1556448207 X-MC-Ingress-Time: 1785493715174 Received: from pdx1-sub0-mail-a203.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.137.223 (trex/8.0.2); Fri, 31 Jul 2026 10:28:35 +0000 Received: from [192.168.0.201] (bl20-181-64.dsl.telepac.pt [2.81.181.64]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a203.dreamhost.com (Postfix) with ESMTPSA id 4hBMjZ1MW3z1H; Fri, 31 Jul 2026 03:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1785493714; bh=CgAMqrX8IlOxNzgTgJmg1bA8nxBv1RcQYvzvsT/rHmk=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=s/i8KnEEcy9jxmYVKD4g3D4m3g/6bP5VdAoaleA4RrGRV0zkpVGyJZVitJTHgbSPS dZbf+FgL0Nhy1b1rgOaahYSoXEAgJznL1OEQC9SIB5zSRmXVGFAfDlum+l7n9H96CA eiGQDUocIyPEPDVuO41lAVpVIKB0Tpig1/MvVoaVhelx7bMqZfISDo/98gAvuC+gdl cuM/iNw+rCkzstk8Ji6fdy3NZt89Q+TMRBPZfSRzed14xveVxTe33FhzLV690XAdoE gqT3q0apxrpTOUbkSxmGCk+Wbb8PdgCM5DAfe3+Hs0dyXc5UWFQJXeWpt7m85a7ATl zsZd851hYm0Hg== Message-ID: Date: Fri, 31 Jul 2026 11:28:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: replace hipcc with amdclang++ as the HIP compiler To: Sarang Patrange , gdb-patches@sourceware.org Cc: Lancelot Six References: <20260715094533.3093704-1-spatrang@amd.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20260715094533.3093704-1-spatrang@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! On 2026-07-15 10:45, Sarang Patrange wrote: > + # amdclang++ requires explicit --offload-arch. Explicitly > + # pass one --offload-arch for each available device. But > + # don't do it if the testcase explicitly used --offload-arch. > + if {[lsearch -exact $options hip_no_offload_arch] == -1 This hip_no_offload_arch check shouldn't be in this patch. That option won't exist until some later yet-sent-to-gdb-patches patch adds it. Noticed because I'm working on preparing said patch. :-) > + && [lsearch -regexp $options "--offload-arch="] == -1} { > + foreach gpu_target [hcc_amdgpu_targets] { > + lappend new_options "early_flags=--offload-arch=$gpu_target"