Re: [PATCH v2 0/5] gdb/aarch64: Support for FPMR

[Luis <luis.machado.foss@gmail.com>]

On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote:
> From: Ezra Sitorus <ezra.sitorus@arm.com>
> 
> The Floating Point Mode Register (FPMR) determines the behaviour of FP8
> instructions. This patch series adds support for this register into gdb.
> 
> I've run the full testsuite on aarch64-none-linux-gnu, and ran the
> gdb.arch tests using Shrinkwrap, which allows me to run Linux on a
> model of an Arm system with new features. You can find more information
> here: [1].
> 
> In v2:
> * I've addressed the various comments on formatting/whitespaces
> * Testing is simplified - there's less repetition of code. I've also
>    removed the remote versions of procedures to run the tests on
>    gdbserver remotely.
> 
> Ezra
> 
> [1]: https://shrinkwrap.docs.arm.com/en/latest/
> 
> Ezra Sitorus (5):
>    gdb/aarch64: Enable FPMR for AArch64 in gdb on Linux
>    gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux
>    gdb/aarch64: signal frame support for fpmr
>    gdb/aarch64: core file support for FPMR
>    gdb/aarch64: Tests for fpmr
> 
>   gdb/aarch64-linux-nat.c                       |  57 +++++++++
>   gdb/aarch64-linux-tdep.c                      | 101 +++++++++++++++
>   gdb/aarch64-tdep.c                            |  18 ++-
>   gdb/aarch64-tdep.h                            |   9 ++
>   gdb/arch/aarch64.c                            |   4 +
>   gdb/arch/aarch64.h                            |  12 +-
>   gdb/features/Makefile                         |   1 +
>   gdb/features/aarch64-fpmr.c                   |  44 +++++++
>   gdb/features/aarch64-fpmr.xml                 |  53 ++++++++
>   gdb/testsuite/gdb.arch/aarch64-fpmr-core.c    |  40 ++++++
>   gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp  |  97 +++++++++++++++
>   .../gdb.arch/aarch64-fpmr-sighandler.c        |  55 ++++++++
>   .../gdb.arch/aarch64-fpmr-sighandler.exp      |  77 ++++++++++++
>   gdb/testsuite/gdb.arch/aarch64-fpmr.c         | 117 ++++++++++++++++++
>   gdb/testsuite/gdb.arch/aarch64-fpmr.exp       |  72 +++++++++++
>   gdb/testsuite/lib/gdb.exp                     |  66 ++++++++++
>   gdbserver/linux-aarch64-low.cc                |  29 +++++
>   17 files changed, 850 insertions(+), 2 deletions(-)
>   create mode 100644 gdb/features/aarch64-fpmr.c
>   create mode 100644 gdb/features/aarch64-fpmr.xml
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.c
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.c
>   create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.exp
> 

Thanks for the updated series. We'll need a documentation entry 
describing the feature and what it does (to the extent that is 
reasonable) and also documentation about the FPMR register set. See the 
gdb manual for the documentation on the other AArch64 register sets.

Also, we will need a NEWS entry for the feature. Again, you can find 
other examples in the gdb/NEWS file.