From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oTZDE0lI6mgeeCkAWB0awg (envelope-from ) for ; Sat, 11 Oct 2025 08:06:33 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=YTiY3t22; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 49C3D1E0B6; Sat, 11 Oct 2025 08:06:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D08C1E047 for ; Sat, 11 Oct 2025 08:06:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 468693857BB3 for ; Sat, 11 Oct 2025 12:06:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 468693857BB3 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=YTiY3t22 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id CB194385843F for ; Sat, 11 Oct 2025 12:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB194385843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB194385843F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::42e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760184357; cv=none; b=WXEg7/r1T0f+DytvIy3DqTPLzYTO1LyjvTYD9P4zhwv3gfRsbhH5y6tYZfCvHYj6NBSopjb8OZAY3CtWOFaTzu1EjnNBrJ1qRUFrUzLXgpJ/a06WTnWH/kQiK+bI98s64vzewFnSSlf4rsCsa5JwyxvVvC1Ct1bo1jvXcGF+Fhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760184357; c=relaxed/simple; bh=l8O0czaKNvQlvufXx/jnjWnIIOamczZVUvT/8h0ku4M=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=exi9fjWFQs2q7sFPyLeNNw+R2aSIfgAQy6e7UeJq7b7AVp79WtofJlS1LgCvmhGnQIJzd72QDSlX/DlDc1Hufw7XBQ6fA4lehSe0ibW9DfVhKlGNsyL7Jex/KWvkOrdEXCZhBtUfPrfQBaHA3SeX4/Yq7M0mTeP7vJbcK8gW9O8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB194385843F Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3f0ae439bc3so1365124f8f.1 for ; Sat, 11 Oct 2025 05:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760184355; x=1760789155; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C1OKh8WwwUBRmYs3ASypQtClY8PbZhRW6YnDSZ6S8Cc=; b=YTiY3t22Pccu5NZmahco6WdwjibG5kQhTA37IlZLa+XicXWVcxq9pwcELFk2zhb5af q9b8nvxiz0Ho3hucvdGgBHYQJq8MdUyk7ERjiWP3xLsIlFp4RkNIq57Sw/BIyWLALpoK Phew28HUwDc2B1TQkAjrPBjhpYWXhB+zzitkXQyTFlvplUnObrWXfa5/x+B3CsB1sqQF b62j87hMnciMd7J7dNW+KK0twe5ZQYTib4DeM4nJtOa5DegRhLYbOm9NvpbXg9WWATab JoF5lBmLiV2K3hUZ95oeTZztpaznkbQz8x5mudE09CtELRdwHe1KCxNlZszUIqCudDgp i/VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760184355; x=1760789155; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C1OKh8WwwUBRmYs3ASypQtClY8PbZhRW6YnDSZ6S8Cc=; b=pka2ei5nJ9fvL1Y8q74FvMH9sf3QSNvfoCn/dLwR78y1KXiU6171POaKgjKMBw1fWy P/iHV2qGaupZo6DvFcgMwtTDz+8F2RSVpRI5qS5JQklZWEuIZdLCX0IiT+NauwgeuJbH zoYeJq6YxlmgIZvpbt4Ee3evd37jjiCgtot9spspFFhtTfpEUA1I7AI2zp7MXoCQJCzb jSd33WUujqdi3oK2FJi+cbzmvXLKKP6520CTq7j4LvZzY8Or8DLws3CJWgmR6GmCA4oI DjyrpWw9jindeJC1dMq1h/xhKhGtqgGhstIf4zaS3CiR8YdpJCRzer+RduCETsKwLxDe os7g== X-Forwarded-Encrypted: i=1; AJvYcCXX07Eqd25EZw5gA7ONGsWJifSHeleL3yqYjctnWfJU3IWPwJO0WtsFZUnIg9RQxUfO6Iy6MJhNzz+bhQ==@sourceware.org X-Gm-Message-State: AOJu0Yy5BNQxuX5tv/UEtsONzmnassfXM3LyQrwkdNW9EXRBsZmZOgZo iMZ9EEsyiN4c7GzaZGNVS62dSVTC+F0V4SM+PoGPUWSmbs//Ws1s7oi4UEBNIg== X-Gm-Gg: ASbGncuOJFSADhyRiyhrBIsSTTwgiUi3Msnd9JM7KZqGLOFoltvEzCE5XmvO6tLpELn 7b+02N2pdVMyNLauWi7TC8w6xkohcqLfBrNCage+gsvt4eODKyjUKzFxZfxfhLaf9fY1plHyb2W VVavNVh9C+vvIQILsK/1GpqrboNKR5lWTvgCpIMhV4iOc8xN9+hcyOWW+xAEkeVQ8RPQrKrpdC7 X4RWlL3DQuwkwtZGgPAVS/e53FCXYqK+UHzxKAihCfUpbOx8b7nr/gFWChbDDm0us4s5dzXCl+A rzBGSHK9pVuMPGIKd73UMGmBw57DTqMkTemap+AM8iaNRnkaavvKdzj+AYMGOlj3LOuylDhTzgG HpaoONzOsmmdKVZke84U4Qa3GBfGVe7dKXPTw8jzWK4sOPZUvd86N0g== X-Google-Smtp-Source: AGHT+IG5G7JMHdzf869BXLqRAJSxAlke/j8Yk2LZbfqK/Oq1oV5wfYFcwTJGF8NJm7B2Xre5xkMt/Q== X-Received: by 2002:a05:6000:491a:b0:426:d53b:4ac with SMTP id ffacd0b85a97d-426d53b05admr1495095f8f.36.1760184355428; Sat, 11 Oct 2025 05:05:55 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57d3desm8793620f8f.7.2025.10.11.05.05.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Oct 2025 05:05:54 -0700 (PDT) Message-ID: Date: Sat, 11 Oct 2025 13:05:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] gdb/aarch64: Support for FPMR Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251007123132.26769-1-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > The Floating Point Mode Register (FPMR) determines the behaviour of FP8 > instructions. This patch series adds support for this register into gdb. > > I've run the full testsuite on aarch64-none-linux-gnu, and ran the > gdb.arch tests using Shrinkwrap, which allows me to run Linux on a > model of an Arm system with new features. You can find more information > here: [1]. > > In v2: > * I've addressed the various comments on formatting/whitespaces > * Testing is simplified - there's less repetition of code. I've also > removed the remote versions of procedures to run the tests on > gdbserver remotely. > > Ezra > > [1]: https://shrinkwrap.docs.arm.com/en/latest/ > > Ezra Sitorus (5): > gdb/aarch64: Enable FPMR for AArch64 in gdb on Linux > gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux > gdb/aarch64: signal frame support for fpmr > gdb/aarch64: core file support for FPMR > gdb/aarch64: Tests for fpmr > > gdb/aarch64-linux-nat.c | 57 +++++++++ > gdb/aarch64-linux-tdep.c | 101 +++++++++++++++ > gdb/aarch64-tdep.c | 18 ++- > gdb/aarch64-tdep.h | 9 ++ > gdb/arch/aarch64.c | 4 + > gdb/arch/aarch64.h | 12 +- > gdb/features/Makefile | 1 + > gdb/features/aarch64-fpmr.c | 44 +++++++ > gdb/features/aarch64-fpmr.xml | 53 ++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr-core.c | 40 ++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp | 97 +++++++++++++++ > .../gdb.arch/aarch64-fpmr-sighandler.c | 55 ++++++++ > .../gdb.arch/aarch64-fpmr-sighandler.exp | 77 ++++++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr.c | 117 ++++++++++++++++++ > gdb/testsuite/gdb.arch/aarch64-fpmr.exp | 72 +++++++++++ > gdb/testsuite/lib/gdb.exp | 66 ++++++++++ > gdbserver/linux-aarch64-low.cc | 29 +++++ > 17 files changed, 850 insertions(+), 2 deletions(-) > create mode 100644 gdb/features/aarch64-fpmr.c > create mode 100644 gdb/features/aarch64-fpmr.xml > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-core.exp > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr-sighandler.exp > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.c > create mode 100644 gdb/testsuite/gdb.arch/aarch64-fpmr.exp > Thanks for the updated series. We'll need a documentation entry describing the feature and what it does (to the extent that is reasonable) and also documentation about the FPMR register set. See the gdb manual for the documentation on the other AArch64 register sets. Also, we will need a NEWS entry for the feature. Again, you can find other examples in the gdb/NEWS file.