Re: [PATCH 3/4] [gdb/testsuite] Add missing type_offset in gdb.dwarf/debug-names-tu.exp

[Tom de Vries <tdevries@suse.de>]

On 5/22/26 5:03 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> With llvm-dwarfdump we run into this warning:
> Tom> ...
> Tom> $ llvm-dwarfdump -a -v debug-names-tu > /dev/null
> Tom> warning: DWARF type unit at offset 0x00000028 has its relocated type_offset \
> Tom>   0x00000028 pointing inside the header
> Tom> ...
> 
> Tom> Fix this by adding the missing type_offset.
> 
> Tom> Likewise in gdb.dwarf2/debug-names-bad-cu-index.exp.
> 
> Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34157
> 
> This looks good but I wonder if the type offset should simply be
> mandatory to 'proc tu'?  Like should it reject an empty string and
> require a real label?
> 

I came across fission-type-unit-locexpr.exp, which has:
...
     # Stub for "int" type unit. 

     tu {
         version 4
     } 0xCAFE1 "" {
         type_unit {
             DW_AT_GNU_dwo_name ${::gdb_test_file_name}.dwo DW_FORM_strp
             DW_AT_comp_dir ${outdir}
	} {
         }
     }
...

We could fix this by doing:
...
+    declare_labels none1
      # Stub for "int" type unit.
      tu {
  	version 4
-    } 0xCAFE1 "" {
+    } 0xCAFE1 none1 {
  	type_unit {
  	    DW_AT_GNU_dwo_name ${::gdb_test_file_name}.dwo DW_FORM_strp
  	    DW_AT_comp_dir ${outdir}
  	} {
+	    none1:
  	}
      }
...
and indeed that fixes the warning, but eventually there might be another 
warning complaining about that (points to abbrev number 0 instead of type).

So I left this as is.

Thanks,
- Tom

> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom