From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2CrXD2FiEWoQOREAWB0awg (envelope-from ) for ; Sat, 23 May 2026 04:16:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2DF591E062; Sat, 23 May 2026 04:16:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1EFF51E062 for ; Sat, 23 May 2026 04:16:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A661148F00AE for ; Sat, 23 May 2026 08:16:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A661148F00AE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 48B2548FE22A for ; Sat, 23 May 2026 08:16:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48B2548FE22A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48B2548FE22A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779524161; cv=none; b=Y048CD0U3CwUed7zByaDYwdICmBURsLGWu9jO8wPCRt60q9YcVQ82C9V2jz+GPHNAR7y2vVsFXHYSI3JiTyD/xOj2pjzi1ezDwCK4OTC/tUWkUNcAxpNhNHHNvEd0cIBl/QRNO0L8a4+p3Mx0GaqeubAaNoewxf8Ha+9ML3lVZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779524161; c=relaxed/simple; bh=eoe7e2Bx5hfzAi3LEctEcBbLX6lxvAvv4g9HXTu4Umg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=hka6AWh1/Wsp7gSRrN4iMBLmI2oENUNY2YWYM6KfCLBwBuA85xQDWBwK3m/5RCbyPndkGpMx/OCDRalllhrC/fMhtIyJFwY5Uv6BwwdBLrnU46yfHy8aqajk482C8g6n32+Hh/iDrzY8liu0TzMjtXAyCjAXgFV4rMI0/jntgBk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=un2YqrbS; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rYZsAM3i DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 48B2548FE22A Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 23AC86BE90; Sat, 23 May 2026 08:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779524160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w39Uoet8USpHjEOGCyug8PgmsxPlyWXstNng970yNYs=; b=un2YqrbS0oLa606qSRysSgrp6yL3dgGCV2E1QK9cC3Bnfk2gr8fazIolQTZrLHCCv1VlXG JSb0G0ufBvpNoqHDnsuWPOje4j9wHKMUNnMDTOiWKoRYsBR0rImmgToZy4wZGEm/8uT4rJ SZw32zDfhp4qrKfLuoyZyiO/weFj5Mk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779524160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w39Uoet8USpHjEOGCyug8PgmsxPlyWXstNng970yNYs=; b=rYZsAM3iEBg8ISvDq5QCGsz/t6yRlhjh1FJPH6Pbdag17cQUK7KCl7n1blHhoNR0E9yyTf FFW+l1/dz8ydmXCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=un2YqrbS; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rYZsAM3i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779524160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w39Uoet8USpHjEOGCyug8PgmsxPlyWXstNng970yNYs=; b=un2YqrbS0oLa606qSRysSgrp6yL3dgGCV2E1QK9cC3Bnfk2gr8fazIolQTZrLHCCv1VlXG JSb0G0ufBvpNoqHDnsuWPOje4j9wHKMUNnMDTOiWKoRYsBR0rImmgToZy4wZGEm/8uT4rJ SZw32zDfhp4qrKfLuoyZyiO/weFj5Mk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779524160; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w39Uoet8USpHjEOGCyug8PgmsxPlyWXstNng970yNYs=; b=rYZsAM3iEBg8ISvDq5QCGsz/t6yRlhjh1FJPH6Pbdag17cQUK7KCl7n1blHhoNR0E9yyTf FFW+l1/dz8ydmXCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 091E4593A8; Sat, 23 May 2026 08:16:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IeWYAEBiEWrbVwAAD6G6ig (envelope-from ); Sat, 23 May 2026 08:16:00 +0000 Message-ID: Date: Sat, 23 May 2026 10:15:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] [gdb/testsuite] Add missing type_offset in gdb.dwarf/debug-names-tu.exp To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260522143737.3373000-1-tdevries@suse.de> <20260522143737.3373000-4-tdevries@suse.de> <87se7j7ahe.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87se7j7ahe.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 23AC86BE90 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid,suse.de:dkim]; internal_greylist_whitelist(0.00)[2a07:de40:b281:104:10:150:64:97]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/22/26 5:03 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> With llvm-dwarfdump we run into this warning: > Tom> ... > Tom> $ llvm-dwarfdump -a -v debug-names-tu > /dev/null > Tom> warning: DWARF type unit at offset 0x00000028 has its relocated type_offset \ > Tom> 0x00000028 pointing inside the header > Tom> ... > > Tom> Fix this by adding the missing type_offset. > > Tom> Likewise in gdb.dwarf2/debug-names-bad-cu-index.exp. > > Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34157 > > This looks good but I wonder if the type offset should simply be > mandatory to 'proc tu'? Like should it reject an empty string and > require a real label? > I came across fission-type-unit-locexpr.exp, which has: ... # Stub for "int" type unit. tu { version 4 } 0xCAFE1 "" { type_unit { DW_AT_GNU_dwo_name ${::gdb_test_file_name}.dwo DW_FORM_strp DW_AT_comp_dir ${outdir} } { } } ... We could fix this by doing: ... + declare_labels none1 # Stub for "int" type unit. tu { version 4 - } 0xCAFE1 "" { + } 0xCAFE1 none1 { type_unit { DW_AT_GNU_dwo_name ${::gdb_test_file_name}.dwo DW_FORM_strp DW_AT_comp_dir ${outdir} } { + none1: } } ... and indeed that fixes the warning, but eventually there might be another warning complaining about that (points to abbrev number 0 instead of type). So I left this as is. Thanks, - Tom > Approved-By: Tom Tromey > > Tom