Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: James Clarke <jrtc27@jrtc27.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
Date: Fri, 19 Jan 2018 16:43:00 -0000	[thread overview]
Message-ID: <a042ce96-940e-2d4e-b70a-d5b280e245dc@redhat.com> (raw)
In-Reply-To: <20171215000434.47315-1-jrtc27@jrtc27.com>

On 12/15/2017 12:04 AM, James Clarke wrote:
> On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
> contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
> define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
> earlier; include it from linux-ptrace.h so it can never come afterwards.

OK.

This allows moving the linux-specific __WCLONE from
gdb_wait.h > linux-ptrace.h, to have it live near where its
sibling __WALL is defined, I think.  (not sure we still support
any system where those two are missing, though.  Maybe we could
just zap them too.)

Thanks,
Pedro Alves


      parent reply	other threads:[~2018-01-19 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  0:04 James Clarke
2017-12-15  0:04 ` [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver James Clarke
2018-01-19 16:48   ` Pedro Alves
2018-01-19 16:55     ` James Clarke
2018-01-19 16:57       ` Pedro Alves
2018-01-19 17:01         ` James Clarke
2018-01-19 16:34 ` [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h James Clarke
2018-01-19 16:43 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a042ce96-940e-2d4e-b70a-d5b280e245dc@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jrtc27@jrtc27.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox