Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: James Clarke <jrtc27@jrtc27.com>
To: gdb-patches@sourceware.org
Cc: James Clarke <jrtc27@jrtc27.com>
Subject: [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
Date: Fri, 15 Dec 2017 00:04:00 -0000	[thread overview]
Message-ID: <20171215000434.47315-1-jrtc27@jrtc27.com> (raw)

On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
earlier; include it from linux-ptrace.h so it can never come afterwards.

gdb/ChangeLog:

	* nat/linux-ptrace.c: Remove unnecessary reinclusion of
	gdb_ptrace.h, and move including gdb_wait.h ...
	* nat/linux-ptrace.h: ... to here.
---
[Originally erroneously sent to the binutils mailing list]

 gdb/nat/linux-ptrace.c |    2 --
 gdb/nat/linux-ptrace.h |    1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/nat/linux-ptrace.c b/gdb/nat/linux-ptrace.c
index 438177f..1240eea 100644
--- a/gdb/nat/linux-ptrace.c
+++ b/gdb/nat/linux-ptrace.c
@@ -21,8 +21,6 @@
 #include "linux-procfs.h"
 #include "linux-waitpid.h"
 #include "buffer.h"
-#include "gdb_wait.h"
-#include "gdb_ptrace.h"
 #ifdef HAVE_SYS_PROCFS_H
 #include <sys/procfs.h>
 #endif
diff --git a/gdb/nat/linux-ptrace.h b/gdb/nat/linux-ptrace.h
index 5954945..6faa89b 100644
--- a/gdb/nat/linux-ptrace.h
+++ b/gdb/nat/linux-ptrace.h
@@ -21,6 +21,7 @@
 struct buffer;

 #include "nat/gdb_ptrace.h"
+#include "gdb_wait.h"

 #ifdef __UCLIBC__
 #if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
--
1.7.10.4


             reply	other threads:[~2017-12-15  0:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  0:04 James Clarke [this message]
2017-12-15  0:04 ` [PATCH 2/2] gdb: Add missing #ifdef USE_THREAD_DB to gdbserver James Clarke
2018-01-19 16:48   ` Pedro Alves
2018-01-19 16:55     ` James Clarke
2018-01-19 16:57       ` Pedro Alves
2018-01-19 17:01         ` James Clarke
2018-01-19 16:34 ` [PATCH 1/2] gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h James Clarke
2018-01-19 16:43 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171215000434.47315-1-jrtc27@jrtc27.com \
    --to=jrtc27@jrtc27.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox