Re: Remove LIBINTL_DEP

[Alan Modra <amodra@gmail.com>]

On Thu, Jun 20, 2024 at 11:31:38AM +0200, Arsen Arsenović wrote:
> Hi Alan,
> 
> Alan Modra <amodra@gmail.com> writes:
> 
> > The intl directory in the source no longer exists.  LIBINTL_DEP is
> > thus always empty.  Remove references to it.
> 
> That's not the case, though - it can be populated by gettext-runtimes
> uninstalled-config.sh via ZW_GNU_GETTEXT_SISTER_DIR.

Oh.

> Are you sure the build still works unchanged without this variable?
> Could you try configuring with in-tree gettext 0.22 or later to check if
> it still works and the proper dependencies are emitted?  I suspect they
> won't be, but that the build will work due to the toplevel dependencies.

It works for me, but that's likely because my uninstalled-config.sh
has

if test no = yes; then
  LIBINTL_DEP="${relative_builddir}/intl/libintl.la"
else
  LIBINTL_DEP=
fi

Hmm, seems I need to configure using --with-included-gettext, and then
the opcodes compile fails because I took LIBINTL out of BUILD_LIBS.
Putting it back in succeeds but if you are building intl in tree then
you really ought to have LIBINTL_DEP.

So the patch is just plain wrong.  Reverting.

-- 
Alan Modra