From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SbOiIQoWdGaLpwAAWB0awg (envelope-from ) for ; Thu, 20 Jun 2024 07:44:10 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=etmo9/Wk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7CF761E0C1; Thu, 20 Jun 2024 07:44:10 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5B2F01E030 for ; Thu, 20 Jun 2024 07:44:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C794D3892470 for ; Thu, 20 Jun 2024 11:44:07 +0000 (GMT) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 132D6388A405; Thu, 20 Jun 2024 11:43:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 132D6388A405 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 132D6388A405 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718883823; cv=none; b=rLkllcU+yN6rLPIbyR/M38soMSk1odu+kL2PAVf6ELv+gWdBoCxpwGPkYJ6k4W4go43QsyQAZ/F9pR21y4/eA5f1inPvLnMXY8RoMLTiOLpSr+GTzNfZstXYRFIYK0YFqXAdW8LrTy9w4GXs364pDHR9Ph8DK0v4iFj3QVEad88= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718883823; c=relaxed/simple; bh=U84EJtRrMk5+ESwvH3tA521eeiPVdqG1/v9MHYWMQ6M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=eV4wFX6L+cRgmoJmIrDWylpIPn4nQvntsTiW/nBXddoRFALaQ207WcseLWvHLe00NoOnG7KQljDzsfs4kSfGOzYvIYV+Ww1C0AFfiL9T34tCTDcy5PBDXcOpztILJ77aoRddOHBMNAkYAclYDAN/6TAdA0IoUSloiteHP46b0og= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1f862f7c7edso6425835ad.3; Thu, 20 Jun 2024 04:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718883821; x=1719488621; darn=sourceware.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=4vMP3kMUKfCo5RGxsZ6jx5DaEz5u//W/ja9YrdkzMa0=; b=etmo9/WkLbOm0EaVHmWc6t2HxyLC1RDAF6ZCTo+SF05ttc1cwUtWjhFSGB0o2JMK4V 5yn8DmGulJI7YblAa2tu6rBJlqVKy+oh8fPyH8uI08riEDi+YkcutRfMiUYY/yJnUDAv wKZBoal7B0uuHcqULrRFMcWEEZrjnnBbsSxvsNt3yt2LKfP0JrKKjZd0cxaPxleLu+WJ s25eDPvNCWmodwY5h/qIawulXMUKiyKWwOtC0+7Nfe94EENx6e4NNMkngF1OFdDfV+Mb y1ZisPDx1X4XWDaw+Sz/KpBqrIK74O3JX1nn+alYNqSiYza+XsLowlWf4KLgPSNNwIV1 0bNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718883821; x=1719488621; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4vMP3kMUKfCo5RGxsZ6jx5DaEz5u//W/ja9YrdkzMa0=; b=hvP4aZC55hQ4r9WeoDoor8zxpvG1PcmqwIsCWmuAfJv79d8HDn0yZXTWt6ulQTRsHU gkuuciipUFLCYv6U8ahc9r1XLQnRk04+qhghBH88GShAPg3vIaV8Ym6C2Lm16xrhnxJy PVa2PaJMpDbuPdefFAe76eZwAGaIgaCEAIyXCiJbqY/2etaUdNHSmxfFPAmMjeuclz+p /16tVNtLLHM3z9guKHJeV3CAFfvncnGc2YPL2LH2pH8nMop01fDnqDsT4zBGmY/BEc5a 1FRbZ7W4aUNTxCXzYl35VQZqZv6+muvCWkpORg87CvErjIZNKSKG8xph9UHqe5isRMx6 Rzpw== X-Forwarded-Encrypted: i=1; AJvYcCU4N1/mymkNUyQJlz83LpjPpsRxyulv9qs+NBNnj8L3I5nxY1AN7lZxyU11ClFfY2EKC/ROgt/dgriD7jRq2f/4cJeA9oTZRykRaw== X-Gm-Message-State: AOJu0Yx8E3BtthtniaghIZBlzX2VIPjBPWaRMBFkzQ+p06GWO+M+c3r2 TtZQpEFHc4y7rdHn/256bD3/y02/GH52pGY/m2tTLHV54MKw/MZqPEVqUw== X-Google-Smtp-Source: AGHT+IFt66A4xW9cHO7Ea/iIMlI25A58F+K/WF5S+LLNlGyhwCOL1uu9UXDB3G+geGtbEDUMIa9oeA== X-Received: by 2002:a17:903:11ce:b0:1f4:b859:cb60 with SMTP id d9443c01a7336-1f9aa396f5amr54784705ad.10.1718883820767; Thu, 20 Jun 2024 04:43:40 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9d99b0105sm5267885ad.78.2024.06.20.04.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 04:43:40 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 9A1E011409F8; Thu, 20 Jun 2024 21:13:37 +0930 (ACST) Date: Thu, 20 Jun 2024 21:13:37 +0930 From: Alan Modra To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: Remove LIBINTL_DEP Message-ID: References: <87zfrggdtx.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zfrggdtx.fsf@aarsen.me> X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Thu, Jun 20, 2024 at 11:31:38AM +0200, Arsen Arsenović wrote: > Hi Alan, > > Alan Modra writes: > > > The intl directory in the source no longer exists. LIBINTL_DEP is > > thus always empty. Remove references to it. > > That's not the case, though - it can be populated by gettext-runtimes > uninstalled-config.sh via ZW_GNU_GETTEXT_SISTER_DIR. Oh. > Are you sure the build still works unchanged without this variable? > Could you try configuring with in-tree gettext 0.22 or later to check if > it still works and the proper dependencies are emitted? I suspect they > won't be, but that the build will work due to the toplevel dependencies. It works for me, but that's likely because my uninstalled-config.sh has if test no = yes; then LIBINTL_DEP="${relative_builddir}/intl/libintl.la" else LIBINTL_DEP= fi Hmm, seems I need to configure using --with-included-gettext, and then the opcodes compile fails because I took LIBINTL out of BUILD_LIBS. Putting it back in succeeds but if you are building intl in tree then you really ought to have LIBINTL_DEP. So the patch is just plain wrong. Reverting. -- Alan Modra