Re: [PATCH] sim: add __attribute__((unused)) to <arch>_fill_argbuf_tp function

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2286 bytes --]

On 14 Dec 2023 21:32, Simon Marchi wrote:
> Btw, is it possible that the dependencies in m32r/local.mk are not
> correct, for the various mloop files?  After applying your patch, I had
> to do a clean first.
> 
> The rule to generate mloop2.c is:
> 
>     %D%/mloop2.c %D%/eng2.h: %D%/stamp-mloop-2 ; @true
>     %D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop.in
> 
> Should it depend on mloop2.in instead of mloop.in?  Likewise for mloopx.

yeah, it should.  m32r is weird in that it has multiple mloop files -- other
ports that generate multiple outputs do it from a single mloop.in input.  so
looks like i missed that when migrating everything to local.mk.  i broke it
with commit 0a129eb19a773d930d60b084209570f663db2053.  pushed the fix below.
-mike

From 10802d9ac0c6e39a672f86224ec89a9a54a37b9c Mon Sep 17 00:00:00 2001
From: Mike Frysinger <vapier@gentoo.org>
Date: Thu, 14 Dec 2023 22:45:22 -0500
Subject: [PATCH] sim: m32r: fix mloop.in variant stamp deps

The migration to local.mk in commit 0a129eb19a773d930d60b084209570f663db2053
accidentally listed the deps for all mloop steps as mloop.in instead of the
various variants that m32r uses.

Reported-by: Simon Marchi <simon.marchi@polymtl.ca>
---
 sim/Makefile.in   | 4 ++--
 sim/m32r/local.mk | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sim/m32r/local.mk b/sim/m32r/local.mk
index 182d8879b434..13f6ea5f9570 100644
--- a/sim/m32r/local.mk
+++ b/sim/m32r/local.mk
@@ -105,7 +105,7 @@ BUILT_SOURCES += \
 
 ## FIXME: Use of `mono' is wip.
 %D%/mloopx.c %D%/engx.h: %D%/stamp-mloop-x ; @true
-%D%/stamp-mloop-x: $(srccom)/genmloop.sh %D%/mloop.in
+%D%/stamp-mloop-x: $(srccom)/genmloop.sh %D%/mloopx.in
 	$(AM_V_GEN)$(SHELL) $(srccom)/genmloop.sh -shell $(SHELL) \
 		-mono -no-fast -pbb -parallel-write -switch semx-switch.c \
 		-cpu m32rxf \
@@ -116,7 +116,7 @@ BUILT_SOURCES += \
 
 ## FIXME: Use of `mono' is wip.
 %D%/mloop2.c %D%/eng2.h: %D%/stamp-mloop-2 ; @true
-%D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop.in
+%D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop2.in
 	$(AM_V_GEN)$(SHELL) $(srccom)/genmloop.sh -shell $(SHELL) \
 		-mono -no-fast -pbb -parallel-write -switch sem2-switch.c \
 		-cpu m32r2f \
-- 
2.43.0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]