Re: [PATCH] sim: add __attribute__((unused)) to <arch>_fill_argbuf_tp function

[Simon Marchi <simark@simark.ca>]

On 2023-12-14 16:39, Mike Frysinger wrote:
> On 14 Dec 2023 11:21, Simon Marchi wrote:
>> I get this when building with --enable-targets=all:
>>
>>       CC       m32r/mloopx.o
>>     m32r/mloopx.c:37:1: error: ‘m32rxf_fill_argbuf_tp’ defined but not used [-Werror=unused-function]
>>        37 | m32rxf_fill_argbuf_tp (const SIM_CPU *cpu, ARGBUF *abuf,
>>           | ^~~~~~~~~~~~~~~~~~~~~
>>
>>       CC       m32r/mloop2.o
>>     m32r/mloop2.c:37:1: error: ‘m32r2f_fill_argbuf_tp’ defined but not used [-Werror=unused-function]
>>        37 | m32r2f_fill_argbuf_tp (const SIM_CPU *cpu, ARGBUF *abuf,
>>           | ^~~~~~~~~~~~~~~~~~~~~
>>
>> I don't know this code, so I didn't do an in-depth analysis of the
>> situation.  Adding the __attribute__((unused)) makes the warning go away
>> (this is what this patch does), but perhaps there's a better way or the
>> warning is the sign that something is wrong.
> 
> pretty sure this is a shortcoming in the m32r mloop2.in & mloopx.in files and
> we should fix it there.  the patch below should fix it.
> 
> it also seems like the loop files are not respecting fast_p, but one thing at a
> time i guess.
> -mike

I know nothing about that code, so I trust you on that.  I tried your
patch, and it works for me, so you can add my:

Tested-By: Simon Marchi <simon.marchi@polymtl.ca>

Btw, is it possible that the dependencies in m32r/local.mk are not
correct, for the various mloop files?  After applying your patch, I had
to do a clean first.

The rule to generate mloop2.c is:

    %D%/mloop2.c %D%/eng2.h: %D%/stamp-mloop-2 ; @true
    %D%/stamp-mloop-2: $(srccom)/genmloop.sh %D%/mloop.in

Should it depend on mloop2.in instead of mloop.in?  Likewise for mloopx.

Simon