From: Jakub Jelinek <jakub@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add some new DW_IDX_* constants
Date: Sat, 9 Dec 2023 23:03:10 +0100 [thread overview]
Message-ID: <ZXTkHpwP1yGsSYNP@tucnak> (raw)
In-Reply-To: <20231209205653.3930232-1-tom@tromey.com>
On Sat, Dec 09, 2023 at 01:56:53PM -0700, Tom Tromey wrote:
> I've reimplemented the .debug_names code in GDB -- it was quite far
> from being correct, and the new implementation is much closer to what
> is specified by DWARF.
>
> However, the new writer in GDB needs to emit some symbol properties,
> so that the reader can be fully functional. This patch adds a few new
> DW_IDX_* constants, and tries to document the existing extensions as
> well. (My patch series add more documentation of these to the GDB
> manual as well.)
LGTM for GCC (but it needs a ChangeLog entry).
> diff --git a/include/dwarf2.def b/include/dwarf2.def
> index 7ab3ee611fd4..75b75d901884 100644
> --- a/include/dwarf2.def
> +++ b/include/dwarf2.def
> @@ -802,8 +802,17 @@ DW_IDX (DW_IDX_parent, 4)
> DW_IDX (DW_IDX_type_hash, 5)
> DW_IDX_DUP (DW_IDX_lo_user, 0x2000)
> DW_IDX (DW_IDX_hi_user, 0x3fff)
> +/* Internal linkage. A flag. */
> DW_IDX (DW_IDX_GNU_internal, 0x2000)
> +/* External linkage. A flag. Note that gdb no longer generates this;
> + the default is to assume external linkage. */
> DW_IDX (DW_IDX_GNU_external, 0x2001)
> +/* This entry is the program's entry point. A flag. */
> +DW_IDX (DW_IDX_GNU_main, 0x2002)
> +/* Language for this entry. A DW_LANG_* value. */
> +DW_IDX (DW_IDX_GNU_language, 0x2003)
> +/* This entry is a linkage name. A flag. */
> +DW_IDX (DW_IDX_GNU_linkage_name, 0x2004)
> DW_END_IDX
>
> /* DWARF5 Unit type header encodings */
> --
> 2.43.0
Jakub
next prev parent reply other threads:[~2023-12-10 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 20:56 Tom Tromey
2023-12-09 22:03 ` Jakub Jelinek [this message]
2023-12-10 20:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXTkHpwP1yGsSYNP@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox