From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +6TcMKcZdmXqLB0AWB0awg (envelope-from ) for ; Sun, 10 Dec 2023 15:03:51 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=INyHKltb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BC62A1E0C3; Sun, 10 Dec 2023 15:03:51 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 810F81E091 for ; Sun, 10 Dec 2023 15:03:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E01C2385800D for ; Sun, 10 Dec 2023 20:03:48 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0A1013858C56 for ; Sun, 10 Dec 2023 20:03:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A1013858C56 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A1013858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702238619; cv=none; b=kSuRj1qdkrYqDgWNXDyyNgAzfISxZ8QI8smVsFg+M0NjxKjm7PWOcajx3qdGcERzAu5WWybwSQoi5/QH6gfbZEgm2OGCHGIJCQWcqVtRaNvQq0KjoGykL2rOXMd3NGCVT2lXtsEXmal12pRK/R+6yfxCerWqKCe8Pf6uL+6HtmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702238619; c=relaxed/simple; bh=8NIvKjBvST+eJq5i1rNcETgEN+gXGn+a/5ycF/0Njlc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=N+GEo1N0rX/UeLXT15F6kndMR8s4etSOsnAC03uYe2r8cZnP6kc5C4K+uBV0Dy6WRnKrFJDU0zRrhGnjHWkLA0SbUHo2tYdhWT+8TeX8sAInOcXIYyLp3FnXvHQgy3ixTqF67GOnr8o8fDtVUUeb9YItw0WN4XhBokWGjp3ro+0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702238617; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Z28BKfUy3HbNYE81BqUgExG8Yiy3HNK4FSD+leDvgKI=; b=INyHKltbm30FIjF2rbGrKIMEufBW0IVtfOi4VOtO69HqWpSn3Toh0RAVvv12FoUJU+am7U Vd2BFDbd8kkvWIGwTDXJhlsG8gWfidGleSom5G5sByZNrHdbxkL9Wu3z1bqfyTgIg+PYx+ tpzaIiYjKpEhrn2owaClZtcQzb11Crg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-MkUF28gAOrq3wTpTiKAu0g-1; Sun, 10 Dec 2023 15:03:34 -0500 X-MC-Unique: MkUF28gAOrq3wTpTiKAu0g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF9AA1C060DE; Sun, 10 Dec 2023 20:03:33 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69F29492BE6; Sun, 10 Dec 2023 20:03:33 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3B9M3Aqh1532266 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sat, 9 Dec 2023 23:06:54 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3B9M3AJq1532265; Sat, 9 Dec 2023 23:03:10 +0100 Date: Sat, 9 Dec 2023 23:03:10 +0100 From: Jakub Jelinek To: Tom Tromey Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Add some new DW_IDX_* constants Message-ID: References: <20231209205653.3930232-1-tom@tromey.com> MIME-Version: 1.0 In-Reply-To: <20231209205653.3930232-1-tom@tromey.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Sat, Dec 09, 2023 at 01:56:53PM -0700, Tom Tromey wrote: > I've reimplemented the .debug_names code in GDB -- it was quite far > from being correct, and the new implementation is much closer to what > is specified by DWARF. > > However, the new writer in GDB needs to emit some symbol properties, > so that the reader can be fully functional. This patch adds a few new > DW_IDX_* constants, and tries to document the existing extensions as > well. (My patch series add more documentation of these to the GDB > manual as well.) LGTM for GCC (but it needs a ChangeLog entry). > diff --git a/include/dwarf2.def b/include/dwarf2.def > index 7ab3ee611fd4..75b75d901884 100644 > --- a/include/dwarf2.def > +++ b/include/dwarf2.def > @@ -802,8 +802,17 @@ DW_IDX (DW_IDX_parent, 4) > DW_IDX (DW_IDX_type_hash, 5) > DW_IDX_DUP (DW_IDX_lo_user, 0x2000) > DW_IDX (DW_IDX_hi_user, 0x3fff) > +/* Internal linkage. A flag. */ > DW_IDX (DW_IDX_GNU_internal, 0x2000) > +/* External linkage. A flag. Note that gdb no longer generates this; > + the default is to assume external linkage. */ > DW_IDX (DW_IDX_GNU_external, 0x2001) > +/* This entry is the program's entry point. A flag. */ > +DW_IDX (DW_IDX_GNU_main, 0x2002) > +/* Language for this entry. A DW_LANG_* value. */ > +DW_IDX (DW_IDX_GNU_language, 0x2003) > +/* This entry is a linkage name. A flag. */ > +DW_IDX (DW_IDX_GNU_linkage_name, 0x2004) > DW_END_IDX > > /* DWARF5 Unit type header encodings */ > -- > 2.43.0 Jakub