From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>
Cc: Chao-ying Fu <cfu@wavecomp.com>,
Faraz Shahbazker <fshahbazker@wavecomp.com>,
gdb-patches@sourceware.org,
"Maciej W . Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH v3 2/4] sim: Factor out NaN handling in floating point operations
Date: Wed, 12 Jan 2022 05:22:35 -0500 [thread overview]
Message-ID: <Yd6r60Jk0iWnvZQD@vapier> (raw)
In-Reply-To: <20220111212406.32312-3-Dragan.Mladjenovic@syrmia.com>
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On 11 Jan 2022 22:24, Dragan Mladjenovic wrote:
> --- a/sim/common/sim-fpu.h
> +++ b/sim/common/sim-fpu.h
>
> +/* NaN handling. */
> +
> +INLINE_SIM_FPU (int) sim_fpu_op_nan (sim_fpu *f,
> + const sim_fpu *l, const sim_fpu *r);
please add a more descriptive comment. the point of the header is for API
documentation so readers can look up to see what this function does.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-12 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 21:24 [PATCH v3 0/4] sim: Add support for MIPS32/64 revision 6 Dragan Mladjenovic
2022-01-11 21:24 ` [PATCH v3 1/4] sim: Allow toggling of quiet NaN-bit semantics Dragan Mladjenovic
2022-01-12 10:06 ` Mike Frysinger via Gdb-patches
2022-01-12 10:44 ` Mike Frysinger via Gdb-patches
2022-01-11 21:24 ` [PATCH v3 2/4] sim: Factor out NaN handling in floating point operations Dragan Mladjenovic
2022-01-12 10:22 ` Mike Frysinger via Gdb-patches [this message]
2022-01-11 21:24 ` [PATCH v3 3/4] sim: Add partial support for IEEE 754-2008 Dragan Mladjenovic
2022-01-12 10:47 ` Mike Frysinger via Gdb-patches
2022-01-11 21:24 ` [PATCH v3 4/4] sim: mips: Add simulator support for mips32r6/mips64r6 Dragan Mladjenovic
2022-01-12 10:57 ` Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd6r60Jk0iWnvZQD@vapier \
--to=gdb-patches@sourceware.org \
--cc=Dragan.Mladjenovic@syrmia.com \
--cc=cfu@wavecomp.com \
--cc=fshahbazker@wavecomp.com \
--cc=macro@orcam.me.uk \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox