From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AzY0HAGs3mEceQAAWB0awg (envelope-from ) for ; Wed, 12 Jan 2022 05:22:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 600181F34E; Wed, 12 Jan 2022 05:22:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D9FD11F0BB for ; Wed, 12 Jan 2022 05:22:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6ACD63858416 for ; Wed, 12 Jan 2022 10:22:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6ACD63858416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641982976; bh=Typ5bMqw3u7+v3uwIL0kgLEFp+kKboqu42QwPwkvGeI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LN+a0YgImkln+Smy0MfVPbQsS8wyz5N2Tx/+FJfCWCofJW9q3Pj7Y1xQW9Kvbl6O4 t8xVNEUI2VyaonMA0YBv+gt4zt4/R+26YlQ2A09BYfsu21kBNDf2Kc1GXar30S1y6S ZZ/kj2s9BlOeRxpOj6zJfhxPvInrC7A+qDw/4PN4= Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1E64A3858416 for ; Wed, 12 Jan 2022 10:22:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E64A3858416 Received: by smtp.gentoo.org (Postfix, from userid 559) id 9E600343242; Wed, 12 Jan 2022 10:22:37 +0000 (UTC) Date: Wed, 12 Jan 2022 05:22:35 -0500 To: Dragan Mladjenovic Subject: Re: [PATCH v3 2/4] sim: Factor out NaN handling in floating point operations Message-ID: Mail-Followup-To: Dragan Mladjenovic , gdb-patches@sourceware.org, "Maciej W . Rozycki" , Chao-ying Fu , Faraz Shahbazker References: <20220111212406.32312-1-Dragan.Mladjenovic@syrmia.com> <20220111212406.32312-3-Dragan.Mladjenovic@syrmia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4GhYwktI/mK9gizj" Content-Disposition: inline In-Reply-To: <20220111212406.32312-3-Dragan.Mladjenovic@syrmia.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Chao-ying Fu , Faraz Shahbazker , gdb-patches@sourceware.org, "Maciej W . Rozycki" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" --4GhYwktI/mK9gizj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11 Jan 2022 22:24, Dragan Mladjenovic wrote: > --- a/sim/common/sim-fpu.h > +++ b/sim/common/sim-fpu.h > =20 > +/* NaN handling. */ > + > +INLINE_SIM_FPU (int) sim_fpu_op_nan (sim_fpu *f, > + const sim_fpu *l, const sim_fpu *r); please add a more descriptive comment. the point of the header is for API documentation so readers can look up to see what this function does. -mike --4GhYwktI/mK9gizj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHeq+sACgkQQWM7n+g3 9YEA7A//SGTnJ7CuKYKxV7qmH1DIk5qOGUtKHQvVrYVikW3RrMZopyGbyx2I6j8Q l81WjJuMIIPxtNOihZNLv2iRdHi25xz114WqFfpXmVHYYlSqjv4k5oF7VrfRDrUI kAKwbYgiBHd/oriu/7z0zb67zXkxmIowPZIb42XlDJzyqGrMxC8jPyap+0TBcBn2 v7AWg0gIG+HEpfOOClsf5/XRgETKU/Y50ixime/Zef8axyhm9Jj01RJdTPguDpec qIJgPPHj9wLqNdy6bTMIqk5Zz1X/2d76Kddo9aPI/c26/D4zfm6Oi9ILtOCbY1Xl vZ1Kj9kMqiXBAFeSOB5KOoQQQlmE71/Zl4a2oXkuh7FZdUPFmabW6sgLBjycyeqv HBagGxS8dLCe2fPF3bEWGUEgDocuUwbGh/O5KmaKMhjo7X+pf/oFoYxwMhf9V3IY UlwIiy+BXOstxGmk13n21poJTSJGnu1V9+DXF5yWWYSgvuJYx/2r2YjKXrCL+YOv CQYJkcF8f7zv8MAZ6bEnSLNM/trzMicZu8SbG9kSYCT+lSGCWhue75gLiIElydYX Ifp26ejewAKIz7U6wtEPNA0enFt/x8xMbOWvBty+VRnMZKEQu7bfyVYpYEn9vJu/ f30BBWi0LwXEYHq75TW8n1jzP3ZYc6pCXuD6Z2PP4CaiHmW/qAU= =5pAU -----END PGP SIGNATURE----- --4GhYwktI/mK9gizj--