Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gnulib: import getline
Date: Tue, 4 May 2021 15:49:21 -0400	[thread overview]
Message-ID: <YJGlQRWKMTZVMQUJ@vapier> (raw)
In-Reply-To: <87im3ys3wz.fsf@tromey.com>

On 04 May 2021 13:19, Tom Tromey wrote:
> >> I saw this build problem internally at AdaCore today, so I appreciate
> >> the quick fix.
> 
> Mike> which subdir & target are you seeing issues with ?  is it sim on Windows ?
> Mike> or is it some other combo ?
> 
> It is a Windows build targeting ARM, and I get:
> 
> ../../../src/sim/arm/../common/sim-hw.c:153:29: warning: implicit declaration of function 'getline' [-Wimplicit-function-declaration]
> 
> and
> 
> [...] ld.exe: libsim.a(sim-hw.o):sim-hw.c:(.text+0x2ae): undefined reference to `getline'

this patch is required, but isn't sufficient, to fix this problem.  i've been
hacking on it a bit.  the sim hasn't used gnulib before, so still need to have
it integrate that dir.

in the meantime, --disable-sim-hardware should fix the build by skipping the
new code that uses getline.
-mike

  reply	other threads:[~2021-05-04 19:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 22:09 Mike Frysinger via Gdb-patches
2021-05-02  0:39 ` Simon Marchi via Gdb-patches
2021-05-02  0:46   ` Mike Frysinger via Gdb-patches
2021-05-02  0:49     ` Simon Marchi via Gdb-patches
2021-05-02  4:50       ` Mike Frysinger via Gdb-patches
2021-05-04 15:03         ` Tom Tromey
2021-05-04 17:46           ` Mike Frysinger via Gdb-patches
2021-05-04 19:19             ` Tom Tromey
2021-05-04 19:49               ` Mike Frysinger via Gdb-patches [this message]
2021-05-04 20:10                 ` Tom Tromey
2021-05-04 21:22                   ` Mike Frysinger via Gdb-patches
2021-05-02  7:14     ` Eli Zaretskii via Gdb-patches
2021-05-02 14:14       ` Mike Frysinger via Gdb-patches
2021-05-02 14:48         ` Eli Zaretskii via Gdb-patches
2021-05-02 15:12           ` Mike Frysinger via Gdb-patches
2021-05-02 15:24             ` Eli Zaretskii via Gdb-patches
2021-05-02 15:47               ` Mike Frysinger via Gdb-patches
2021-05-02 16:06                 ` Eli Zaretskii via Gdb-patches
2021-05-02 16:12                   ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJGlQRWKMTZVMQUJ@vapier \
    --to=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox