From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eJm/GkilkWAhawAAWB0awg (envelope-from ) for ; Tue, 04 May 2021 15:49:28 -0400 Received: by simark.ca (Postfix, from userid 112) id 5E9281F11C; Tue, 4 May 2021 15:49:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7118F1E54D for ; Tue, 4 May 2021 15:49:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD1D9396901B; Tue, 4 May 2021 19:49:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD1D9396901B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620157766; bh=eNilLK13/X+7Jo3AJg83nUDgIrlJWTfKPNCdw68MTkk=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Fcqwjz4ztXbqm1UQCWllQ+KFkOLidOTdufrEMiEAasuV6w4hP9jnu01HUUFP3eY+u zZAFFVSXrMNoviibsOqG3Opm4GOqnpBI8zAI4+B5FuEVHy4qXJ9Z6NEAtwf4IWL/oh BxzTPAKAw3BjzQ/WikT3K3x5kOkjxqPQHryTtLMc= Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 675E7395C41A for ; Tue, 4 May 2021 19:49:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 675E7395C41A Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1E58433BE23; Tue, 4 May 2021 19:49:22 +0000 (UTC) Date: Tue, 4 May 2021 15:49:21 -0400 To: Tom Tromey Subject: Re: [PATCH] gnulib: import getline Message-ID: Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <20210501220936.30972-1-vapier@gentoo.org> <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca> <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca> <874kfituax.fsf@tromey.com> <87im3ys3wz.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87im3ys3wz.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 04 May 2021 13:19, Tom Tromey wrote: > >> I saw this build problem internally at AdaCore today, so I appreciate > >> the quick fix. > > Mike> which subdir & target are you seeing issues with ? is it sim on Windows ? > Mike> or is it some other combo ? > > It is a Windows build targeting ARM, and I get: > > ../../../src/sim/arm/../common/sim-hw.c:153:29: warning: implicit declaration of function 'getline' [-Wimplicit-function-declaration] > > and > > [...] ld.exe: libsim.a(sim-hw.o):sim-hw.c:(.text+0x2ae): undefined reference to `getline' this patch is required, but isn't sufficient, to fix this problem. i've been hacking on it a bit. the sim hasn't used gnulib before, so still need to have it integrate that dir. in the meantime, --disable-sim-hardware should fix the build by skipping the new code that uses getline. -mike