From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>
Cc: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 5/6] sim: callback: convert time interface to 64-bit
Date: Sat, 24 Apr 2021 18:36:51 -0400 [thread overview]
Message-ID: <YISdg8Jf9w7DndSk@vapier> (raw)
In-Reply-To: <87mttne6cb.fsf@tromey.com>
On 24 Apr 2021 15:11, Tom Tromey wrote:
> >>>>> "Mike" == Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Mike> Rather than rely on time_t being the right size between the host &
> Mike> target, have the interface always be 64-bit. We can figure out if
> Mike> we need to truncate when actually outputting it to the right target.
>
> Mike> - long (*time) (host_callback *, long *);
> Mike> + int64_t (*time) (host_callback *, int64_t *);
>
> It is possible to remove the 'int64_t *' parameter here?
> The Linux time(2) man page says:
>
> The tloc argument is obsolescent and should always be NULL in new code.
> When tloc is NULL, the call cannot fail.
>
> And, it does seem redundant.
sure, if we're going to change the API, might as well only do it once.
it'll simplify the body too.
-mike
next prev parent reply other threads:[~2021-04-24 22:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 18:41 [PATCH 1/6] gdb: callback: always include necessary headers Mike Frysinger via Gdb-patches
2021-04-24 18:41 ` [PATCH 2/6] gdb: callback: use ATTRIBUTE_NORETURN Mike Frysinger via Gdb-patches
2021-04-24 18:41 ` [PATCH 3/6] gdb: callback: inline PTR define Mike Frysinger via Gdb-patches
2021-04-24 18:41 ` [PATCH 4/6] sim: callback: inline wrap helper Mike Frysinger via Gdb-patches
2021-04-24 18:41 ` [PATCH 5/6] sim: callback: convert time interface to 64-bit Mike Frysinger via Gdb-patches
2021-04-24 21:11 ` Tom Tromey
2021-04-24 22:36 ` Mike Frysinger via Gdb-patches [this message]
2021-05-14 5:39 ` [PATCH 5/6 v2] " Mike Frysinger via Gdb-patches
2021-05-14 14:00 ` Tom Tromey
2021-04-24 18:41 ` [PATCH 6/6] sim: callback: convert FS interfaces " Mike Frysinger via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YISdg8Jf9w7DndSk@vapier \
--to=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox