From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id n9PRMoidhGD8MwAAWB0awg (envelope-from ) for ; Sat, 24 Apr 2021 18:36:56 -0400 Received: by simark.ca (Postfix, from userid 112) id C96811F11C; Sat, 24 Apr 2021 18:36:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 48C6B1E54D for ; Sat, 24 Apr 2021 18:36:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED288396901F; Sat, 24 Apr 2021 22:36:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED288396901F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619303816; bh=HRi/eFOztbk4f6RIGDp7IERP+5l0cLP9NRjXzra5TIw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WQlL5X4+tf/kyisGnZbNtrH4yXmx82L0HTjLHWFELFCs2085amGKD1yP6mgF3P+T1 sn6ZIFXmh/mshSQS6jPmiKkm3uwerGeVIz/kblT9YOVQb2WXzxT/zNa3ZjqfjH5qbG NyzKVFWYWxyHVjqCDh171IAtBEbpJm7kqVYeFuHY= Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 683F13844028 for ; Sat, 24 Apr 2021 22:36:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 683F13844028 Received: from vapier (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A81C9340E61; Sat, 24 Apr 2021 22:36:52 +0000 (UTC) Date: Sat, 24 Apr 2021 18:36:51 -0400 To: Tom Tromey Subject: Re: [PATCH 5/6] sim: callback: convert time interface to 64-bit Message-ID: Mail-Followup-To: Tom Tromey , Mike Frysinger via Gdb-patches References: <20210424184144.23736-1-vapier@gentoo.org> <20210424184144.23736-5-vapier@gentoo.org> <87mttne6cb.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87mttne6cb.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Cc: Mike Frysinger via Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 24 Apr 2021 15:11, Tom Tromey wrote: > >>>>> "Mike" == Mike Frysinger via Gdb-patches writes: > > Mike> Rather than rely on time_t being the right size between the host & > Mike> target, have the interface always be 64-bit. We can figure out if > Mike> we need to truncate when actually outputting it to the right target. > > Mike> - long (*time) (host_callback *, long *); > Mike> + int64_t (*time) (host_callback *, int64_t *); > > It is possible to remove the 'int64_t *' parameter here? > The Linux time(2) man page says: > > The tloc argument is obsolescent and should always be NULL in new code. > When tloc is NULL, the call cannot fail. > > And, it does seem redundant. sure, if we're going to change the API, might as well only do it once. it'll simplify the body too. -mike