From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: sprinkle some ATTRIBUTE_PRINTF
Date: Thu, 22 Apr 2021 10:21:45 -0400 [thread overview]
Message-ID: <YIGGeVveAKRPwnAQ@vapier> (raw)
In-Reply-To: <20210422134344.3303416-1-simon.marchi@polymtl.ca>
On 22 Apr 2021 09:43, Simon Marchi via Gdb-patches wrote:
> Add some ATTRIBUTE_PRINTF attributes to functions that take a format
> string, to fix a few -Wformat-nonliteral warnings. Use the
> ATTRIBUTE_PRINTF macro like we use in GDB, instead of spelling out
> __attribute__((format...)). Use ATTRIBUTE_NULL_PRINTF at one place,
> because callers expect to be able to pass NULL.
lgtm, thanks
-mike
prev parent reply other threads:[~2021-04-22 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 13:43 Simon Marchi via Gdb-patches
2021-04-22 14:21 ` Mike Frysinger via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIGGeVveAKRPwnAQ@vapier \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox