From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-bounces@sourceware.org>
Received: from simark.ca
	by simark.ca with LMTP
	id QBRqAIKGgWDcXAAAWB0awg
	(envelope-from <gdb-patches-bounces@sourceware.org>)
	for <public-inbox@simark.ca>; Thu, 22 Apr 2021 10:21:54 -0400
Received: by simark.ca (Postfix, from userid 112)
	id F39E31F104; Thu, 22 Apr 2021 10:21:53 -0400 (EDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.2
Received: from sourceware.org (server2.sourceware.org [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPS id D64D51E783
	for <public-inbox@simark.ca>; Thu, 22 Apr 2021 10:21:52 -0400 (EDT)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 908B03894C3B;
	Thu, 22 Apr 2021 14:21:52 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 908B03894C3B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1619101312;
	bh=w1mUNbzOkiXxz8S0ydYzDUPLRX0aM2tfgnoxbpc94c4=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=etC6NBDPF1FIgKW1wpRCOj3nVnEPO37jwaDioWi8QMWV5GVcELSzU4L+YDBrv7DRn
	 +CbeTSTI+C7xxdsUJbw43bJMCAPOThj212XwWzkgd3PguYBM7Qow6O//i4A67I4sC5
	 JEbnfBab4LmQ1tdDcF6OQe4QgCD5+gJVBX0mnD0A=
Received: from smtp.gentoo.org (dev.gentoo.org
 [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
 by sourceware.org (Postfix) with ESMTP id 5AE953894C25
 for <gdb-patches@sourceware.org>; Thu, 22 Apr 2021 14:21:48 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5AE953894C25
Received: from vapier (localhost [127.0.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smtp.gentoo.org (Postfix) with ESMTPS id D068933D5A5;
 Thu, 22 Apr 2021 14:21:46 +0000 (UTC)
Date: Thu, 22 Apr 2021 10:21:45 -0400
To: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] sim: sprinkle some ATTRIBUTE_PRINTF
Message-ID: <YIGGeVveAKRPwnAQ@vapier>
Mail-Followup-To: Simon Marchi <simon.marchi@polymtl.ca>,
 gdb-patches@sourceware.org
References: <20210422134344.3303416-1-simon.marchi@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210422134344.3303416-1-simon.marchi@polymtl.ca>
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
Reply-To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Errors-To: gdb-patches-bounces@sourceware.org
Sender: "Gdb-patches" <gdb-patches-bounces@sourceware.org>

On 22 Apr 2021 09:43, Simon Marchi via Gdb-patches wrote:
> Add some ATTRIBUTE_PRINTF attributes to functions that take a format
> string, to fix a few -Wformat-nonliteral warnings.  Use the
> ATTRIBUTE_PRINTF macro like we use in GDB, instead of spelling out
> __attribute__((format...)).  Use ATTRIBUTE_NULL_PRINTF at one place,
> because callers expect to be able to pass NULL.

lgtm, thanks
-mike