From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary
Date: Sun, 2 May 2021 11:43:42 -0400 [thread overview]
Message-ID: <YI7IrnjosWGDOzHS@vapier> (raw)
In-Reply-To: <20210502152454.506379-1-simon.marchi@polymtl.ca>
On 02 May 2021 11:24, Simon Marchi via Gdb-patches wrote:
> I finally got the all-targets sim building with Clang, these are all the
> instances where an ATTRIBUTE_PRINTF or ATTRIBUTE_NULL_PRINTF attribute
> needed to be added to avoid errors like:
>
> /home/simark/src/binutils-gdb/sim/aarch64/../common/sim-profile.c:464:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
> vfprintf (fp, fmt, ap);
> ^~~
> There are more fixes needed to get everything building, but adding these
> attributes is trivial enough, so I send them all in a single patch.
lgtm, thanks
-mike
next prev parent reply other threads:[~2021-05-02 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 15:24 Simon Marchi via Gdb-patches
2021-05-02 15:43 ` Mike Frysinger via Gdb-patches [this message]
2021-05-02 16:07 ` Simon Marchi via Gdb-patches
2021-05-02 17:07 ` Mike Frysinger via Gdb-patches
2021-05-03 14:55 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI7IrnjosWGDOzHS@vapier \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox